GNOME Bugzilla – Bug 615060
dvdnav: implement GstStream API to allow switching DVD angles in playbin3
Last modified: 2018-11-03 13:05:35 UTC
When watching a DVD, we should be told when the number of viewing angles changes through the "n-video" playbin2 property and allow switching between angles through it as well. That would make it possible to make the "Next Angle" button unsensitive when there's only one angle available.
Or perhaps this should be done via TOC messages now ?
Actually, when this bug was filed, that information was already available by sending Navigation Command messages and the associated Angles queries
So what's the deal with this then? Should playbin catch those messages and signal n-video accordingly? Do we handle angles via current-video at all?
No, angles are purely via the NavigationCommand interface. I guess it could proxy via the n-video/current-video properties too, although it can change during a DVD - it's always 1 in the DVD menu, and then may advertise more during the main feature.
(In reply to comment #2) > Actually, when this bug was filed, that information was already available by > sending Navigation Command messages and the associated Angles queries Getting a signal/notify for that is nicer. (In reply to comment #4) > No, angles are purely via the NavigationCommand interface. I guess it could > proxy via the n-video/current-video properties too, although it can change > during a DVD - it's always 1 in the DVD menu, and then may advertise more > during the main feature. Can we only poll for that then? If so, n-video proxying it is still nice, as we could poke the navigation interface, and handle n-video/current-video through one code path instead of 2.
I would have thought the message was nicer, since the signal will be notified from the streaming thread and require marshalling into the main thread - the navigation message just arrives on the bus in the main loop
We currently handle it by polling on track changes with that code: http://git.gnome.org/browse/totem/tree/src/backend/bacon-video-widget.c#n5054 Do a search for "->has_angles" in the code. We could remove all that special handling.
I don't think this will be fixed in playbin2. I think the way forward is to implement the GstStream API.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/17.