After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614978 - conversation disappeared from the message tray
conversation disappeared from the message tray
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-06 16:13 UTC by William Jon McCann
Modified: 2010-04-13 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
notificationDaemon: fix remove-source-on-app-focus code (1.05 KB, patch)
2010-04-08 15:41 UTC, Dan Winship
committed Details | Review

Description William Jon McCann 2010-04-06 16:13:35 UTC
After the interaction from bug 614975 the conversation left the message tray.  I wouldn't expect it to go away until after a few minutes have passed.
Comment 1 Dan Winship 2010-04-08 15:41:55 UTC
Created attachment 158214 [details] [review]
notificationDaemon: fix remove-source-on-app-focus code

Previously when no app was focused it would accidentally remove all
sources that had no assocated app (such as telepathy-based sources).
Comment 2 Owen Taylor 2010-04-13 15:23:13 UTC
Review of attachment 158214 [details] [review]:

Patche looks good to me. (maybe MessageTray.removeSourceByApp() should get a assertion that the app is not null? do we have a way of doing assertions?)
Comment 3 Dan Winship 2010-04-13 15:51:07 UTC
Attachment 158214 [details] pushed as a7cd294 - notificationDaemon: fix remove-source-on-app-focus code