After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614903 - g_callable_info_prepare_closure: handle SELinux
g_callable_info_prepare_closure: handle SELinux
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-04-05 19:28 UTC by Dan Winship
Modified: 2015-02-07 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
g_callable_info_prepare_closure: handle SELinux (4.19 KB, patch)
2010-04-05 19:28 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2010-04-05 19:28:10 UTC 
after reinstalling, I accidentally had selinux enabled, and gnome-shell
was crashing. This fixes it.
Comment 1 Dan Winship 2010-04-05 19:28:12 UTC 
Created attachment 157997 [details] [review]
g_callable_info_prepare_closure: handle SELinux

If a process is being protected by SELinux, it cannot mmap() a segment
both writable and executable, which was causing
g_callable_info_prepare_closure() to fail. Libffi has a workaround for
this problem though (it maps the same non-anonymous region twice, once
writable and once executable, and returns two separate pointers to
it), so use that.
Comment 2 Johan (not receiving bugmail) Dahlin 2010-04-05 19:38:20 UTC 
Review of attachment 157997 [details] [review]:

This looks good.

The only thing I could think of is that ffi_closure_alloc might not be present in all
currently supported libffi versions. But let's just see if anyone complains before
worrying about that.
Comment 3 Colin Walters 2010-04-05 21:19:23 UTC 
Review of attachment 157997 [details] [review]:

I'd prefer if the commit message says "Handle non-W|X heaps" or something like that; SELinux is just a mechanism used to enforce that policy.
Comment 4 Dan Winship 2010-04-06 12:38:46 UTC 
updated comment and committed
Comment 5 André Klapper 2015-02-07 16:46:39 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]