After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614879 - Can't launch Wine apps
Can't launch Wine apps
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Colin Walters
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-05 15:34 UTC by Milan Bouchet-Valat
Modified: 2010-10-11 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[ShellAppSystem] Don't use g_desktop_app_info_new (1001 bytes, patch)
2010-06-11 13:26 UTC, Maxim Ermilov
reviewed Details | Review
[ShellAppSystem] Don't use g_desktop_app_info_new (1.46 KB, patch)
2010-07-02 19:08 UTC, Maxim Ermilov
committed Details | Review

Description Milan Bouchet-Valat 2010-04-05 15:34:10 UTC
I'm unable to start Wine apps for a few days (not sure a commit broke this recently). On right click, I can only choose "Add to favorites", and left click has no effect, both from search and apps list.

    JS ERROR: !!!   Exception was: Error: Error invoking Shell.launch: Not found
    JS ERROR: !!!     lineNumber = '0'
    JS ERROR: !!!     fileName = 'gjs_throw'
    JS ERROR: !!!     message = 'Error invoking Shell.launch: Not found'
    JS ERROR: !!!     stack = 'Error("Error invoking Shell.launch: Not found")@:0
("Error invoking Shell.launch: Not found")@gjs_throw:0
@:0
("wine-Programmes-SAS-SAS 9.1 (Fran\xE7ais).desktop")@/opt/gnome-shell/share/gnome-shell/js/ui/appDisplay.js:295
()@/opt/gnome-shell/share/gnome-shell/js/ui/appDisplay.js:263
()@/opt/gnome-shell/share/gnome-shell/js/ui/dash.js:605
([object _private_St_IMText])@/opt/gnome-shell/share/gnome-shell/js/ui/dash.js:849
([object _private_St_IMText])@/opt/gnome-shell/share/gjs-1.0/lang.js:110
Error("Chained exception")@:0
("Chained exception")@gjs_throw:0
Comment 1 Milan Bouchet-Valat 2010-04-06 08:30:54 UTC
I could have been more explicit: Wine .desktop files are in ~/.config/Wine/Programmes/XXX.desktop. So maybe the problem is with subdirectories (in the message, slashes are replaced with dashes).
Comment 2 Jonathan Strander 2010-04-20 21:52:50 UTC
I can confirm this bug also occurs on my box. I can't recall the exact revision it started on, but it was around the end of March/beginning of April.
Comment 3 Maxim Ermilov 2010-06-11 13:26:02 UTC
Created attachment 163387 [details] [review]
[ShellAppSystem] Don't use g_desktop_app_info_new

wine desktop files located at ~/.local/share/applications/wine/Programs/.../XXX.desktop.


g_desktop_app_info_new doesn't fully support convert id to path. For example: multiply subdirs (our case), "LegacyDir prefix" in .menu files...
Comment 4 Colin Walters 2010-07-02 18:24:23 UTC
Review of attachment 163387 [details] [review]:

::: src/shell-app-system.c
@@ +1306,2 @@
       return TRUE;
     }

I'd prefer to see this call:

filename = gmenu_tree_entry_get_desktop_file_path (info->entry);
gapp = g_desktop_app_info_new_from_filename (filename);
Comment 5 Maxim Ermilov 2010-07-02 19:08:00 UTC
Created attachment 165134 [details] [review]
[ShellAppSystem] Don't use g_desktop_app_info_new
Comment 6 Colin Walters 2010-10-07 18:11:11 UTC
Review of attachment 165134 [details] [review]:

Looks OK, but can you add a comment /* Can't use g_desktop_app_info_new, see bug 614879 */

We'll have to keep this kind of thing in mind when we eventually switch away from gnome-menus.