GNOME Bugzilla – Bug 614804
[PATCH] v4l2sink: support for OMAP v4l2 display drivers
Last modified: 2011-05-24 08:37:18 UTC
add driver specific work-arounds for the v4l2 display drivers on various versions of OMAP. These two patches will not cause any problems on other drivers, but allow v4l2sink to work out of the box on OMAP platforms.
Created attachment 157876 [details] [review] Add support for omap24xxvout driver
Created attachment 157877 [details] [review] Add support for omap_vout driver
(In reply to comment #0) > add driver specific work-arounds for the v4l2 display drivers on various > versions of OMAP. These two patches will not cause any problems on other > drivers, but allow v4l2sink to work out of the box on OMAP platforms. oh, I should mention that this would apply cleanly on top of the patches in #612244
Driver-specific hacks seem very wrong to me. Can't this be fixed in the driver or at the v4l2 layer?
Agreed that proper fix should be in driver. But there are still kernels in use with the older buggy driver versions. These omap24xxvout patch is for support of legacy/deprecated driver (pre-dss2).. because there are still older kernels floating around. In the case of the omap_vout driver, I believe the issue has been fixed in current versions of the driver, although there is not yet a good way to differentiate from userspace between older buggy version of driver and newer. (I had proposed to display driver team to give the newer driver a different name to differentiate from userspace.) So these patches are mainly so that v4l2sink just works out of the box, even if you are using it with an old kernel. If that is not a concern, then the patches aren't needed. Although the patches are relatively localized so it seemed like a small price to pay for wider interoperability.
Reopened as I think the requested information has been provided.
Closing as WONTFIX because we don't want to work around driver bugs and add hacks for specific hardware.