After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614756 - Scrobble Internet radio too
Scrobble Internet radio too
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Last.fm
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
: 617559 665992 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-03 18:15 UTC by Jakub 'Livio' Rusinek
Modified: 2020-03-17 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jakub 'Livio' Rusinek 2010-04-03 18:15:22 UTC
Some I-net radio stations like http://files.kusmierz.be/rmf/rmfdepechemode.pls (this URL is a workaround to play RMF FM Depeche Mode in non-WMP players) send artist and title info.

Would be nice to get them scrobbled too.
Comment 1 Jeff Payne 2010-04-10 20:22:24 UTC
I second this one.  Seems like it might be an easy win for the last.fm plugin seeing as how the data is already being captured in some respect to display it in the Now Playing section.
Comment 2 Michael Martin-Smucker 2010-05-03 18:47:15 UTC
*** Bug 617559 has been marked as a duplicate of this bug. ***
Comment 3 Fabricio 2010-08-29 01:25:35 UTC
I was looking for a way to implement this type of feature.
Looking at the code for the audioscrobler plugin I found at "rb-audioscrobbler-entry.c" at method "rb_audioscrobbler_entry_create" its executed the queries for information about the entry:

	as_entry->title = rhythmdb_entry_dup_string (rb_entry, RHYTHMDB_PROP_TITLE);
	as_entry->track = rhythmdb_entry_get_ulong (rb_entry, RHYTHMDB_PROP_TRACK_NUMBER);
	as_entry->artist = rhythmdb_entry_dup_string (rb_entry, RHYTHMDB_PROP_ARTIST);
	as_entry->album = rhythmdb_entry_dup_string (rb_entry, RHYTHMDB_PROP_ALBUM);

I'm writing a plugin (for another feature, and in phyton, github.com/nuk/CopyName2Clipboard) that does this trick. I haven't found an way to recompile the audioscrobler (i didn't researched much yet) so I may not be of much help right now.
Comment 4 Fabricio 2010-08-29 01:28:08 UTC
Please, ignore my comment. It was intended for the rhythmbox.
Comment 5 Sebastian Krämer 2011-07-04 20:04:50 UTC
Does audioscrobbler allow scrobbling of "classical" streams radio? I thought it does not but am not 100% sure..
(I'd really like banshee to scrobble these..)
Comment 6 Thomas Leberbauer 2011-11-07 14:30:35 UTC
Internet radio should definately be scrobbled. In general the audioscrobbler should not care what source a currently played music title comes from.
Comment 7 Bertrand Lorentz 2011-12-12 12:22:30 UTC
*** Bug 665992 has been marked as a duplicate of this bug. ***
Comment 8 Bertrand Lorentz 2011-12-12 12:23:48 UTC
I'm not sure scrobbling tracks from radio streams is a good idea, because metadata from radio streams is often unreliable : I've seen stations mixing up artist name and album title, or putting other stuff in there, for example when playing ads.

But if we do scrobble radio streams, we need to make sure we set the "chosenByUser" parameter to false:
http://www.last.fm/api/scrobbling#when-to-set-the-chosenbyuser-parameter
Comment 9 Daniel Lo Nigro 2011-12-12 12:33:00 UTC
In that case, perhaps have it as a user-selectable option that's turned off by default? That way, users can decide if they want to scrobble tracks from radio streams (and get potentially unreliable data).
Comment 10 Fabricio 2011-12-12 12:46:54 UTC
(In reply to comment #9)
> In that case, perhaps have it as a user-selectable option that's turned off by
> default? That way, users can decide if they want to scrobble tracks from radio
> streams (and get potentially unreliable data).

That'd be the best option.
Comment 11 Daniel Lo Nigro 2011-12-12 21:48:25 UTC
I'm not experienced with the Banshee codebase at all, but it looks like you'd need to do something like the following:

 - Edit OnPlayerEvent in Banshee.Lastfm.Audioscrobbler.AudioscrobblerService to handle the "PlayerEvent.TrackInfoUpdated" event
 - In there, check if ServiceManager.PlayerEngine.CurrentTrack is an instance of RadioTrackInfo
    - If so, only scrobble if the "Scrobble streaming radio tracks" option is enabled
Comment 12 Xico 2012-07-20 15:35:29 UTC
Please, internet radio should be scrobbled ... im a big fan of rhythmbox.

some reference of parsing ICY protocol: http://forums.radiotoolbox.com/viewtopic.php?t=74

Thank you.
Comment 13 André Klapper 2020-03-17 08:55:38 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.