After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614704 - css style doesn't override presentation attributes
css style doesn't override presentation attributes
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-03 03:53 UTC by Matthias Clasen
Modified: 2010-04-14 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1015 bytes, patch)
2010-04-03 03:53 UTC, Matthias Clasen 		committed Details | Review
test image (398 bytes, image/svg+xml)
2010-04-05 12:36 UTC, Matthias Clasen 		  Details

Description Matthias Clasen 2010-04-03 03:53:51 UTC 
Created attachment 157785 [details] [review]
patch

According to the svg spec, css styles should override presentation attributes such as fill="black" that are specified directly in the svg. The attached patch has this effect, by parsing the presentation attributes before looking for a style matching class/id.
Comment 1 Hiroyuki Ikezoe 2010-04-05 10:37:54 UTC 
Can you attach an example SVG file for this bug, please? I am planning to write test codes for CSS handling and would like to get the test case for this bug in the codes.
Comment 2 Hiroyuki Ikezoe 2010-04-05 11:41:54 UTC 
I filed a test code bug. Bug #614866.
Comment 3 Matthias Clasen 2010-04-05 12:36:50 UTC 
Created attachment 157969 [details]
test image

Here is an example. This comes up blue in firefox (according to spec), but shows up red in eog (using librsvg).
Comment 4 Hiroyuki Ikezoe 2010-04-06 10:53:42 UTC 
Thanks! I added this test case into the patch for bug 614866.
Comment 5 Hiroyuki Ikezoe 2010-04-14 07:03:57 UTC 
Comment on attachment 157785 [details] [review]
patch

Committed without debug print and check the existence of property bag.