After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614643 - does not handle comma separated CSS selector without libcroco
does not handle comma separated CSS selector without libcroco
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks: 614606
 
 
Reported: 2010-04-02 04:01 UTC by Hiroyuki Ikezoe
Modified: 2010-04-24 07:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.21 KB, patch)
2010-04-02 04:01 UTC, Hiroyuki Ikezoe 		needs-work Details | Review
Revised patch (3.17 KB, patch)
2010-04-22 11:38 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description Hiroyuki Ikezoe 2010-04-02 04:01:47 UTC 
Created attachment 157734 [details] [review]
Proposed patch

CSS parser in librsvg does not handle comma separated selector. So the attachement svg in bug #614606 does not render correct colors.
Comment 1 Hiroyuki Ikezoe 2010-04-22 11:37:33 UTC 
Comment on attachment 157734 [details] [review]
Proposed patch

This patch does not work well in the case of a space followed by comma.
Comment 2 Hiroyuki Ikezoe 2010-04-22 11:38:14 UTC 
Created attachment 159324 [details] [review]
Revised patch

Fix with test cases.
Comment 3 Hiroyuki Ikezoe 2010-04-24 07:32:20 UTC 
Comment on attachment 159324 [details] [review]
Revised patch

This patch did not include test svg file.
Committed with the file.