GNOME Bugzilla – Bug 614575
emerillon is broken with gtk 2.20.0
Last modified: 2010-04-20 20:46:59 UTC
Hi, emerillon is broken with new gtk: gmodule-2.0.so -ldl /usr/lib/libgthread-2.0.so -lrt /usr/lib/libglib-2.0.so ../cut-paste/.libs/libephyspinner.a -pthread window.o: In function `sidebar_visibility_changed_cb': window.c:(.text+0x10c4): undefined reference to `GTK_WIDGET_VISIBLE' sidebar.o: In function `emerillon_sidebar_menu_position_under': sidebar.c:(.text+0x12ee): undefined reference to `GTK_WIDGET_NO_WINDOW' collect2: ld returned 1 exit status make[4]: *** [emerillon] Error 1 make[4]: Leaving directory `/var/tmp/fst/src/emerillon-0.1.1/emerillon' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/var/tmp/fst/src/emerillon-0.1.1/emerillon' make[2]: *** [all] Error 2 make[2]: Leaving directory `/var/tmp/fst/src/emerillon-0.1.1/emerillon' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/fst/src/emerillon-0.1.1' make: *** [all] Error 2
What's your value of --enable-deprecations ?
hi, Thanks fixed with --enable-deprecations=no
Created attachment 158279 [details] [review] Bump required Gtk+ version to 2.20
Created attachment 158280 [details] [review] Replace deprecated macros with new accessors. GTK_WIDGET_NO_WINDOW and GTK_WINDGET_VISIBLE is deprecated in Gtk+ 2.20 and since emerillon compiles with deprecations enabled by default this makes it fail to build with Gtk 2.20.
Created attachment 158281 [details] [review] Replace cut-n-paste ephy_spinner with Gtk spinner. There is a spinner included in Gtk+ since atleast 2.20.
I don't have Gtk+ 2.20 yet, if someone can confirm these patch works, I'd commit them.
Works for me with those patches. Although the GSEAL migration isn't complete yet
Patches pushed. I squashed two commits if you don't mind. I can't close this bug until I get the proper bugzilla permissions though…