After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614513 - Func to substitute GTK_WIDGET_SET_FLAGS (widget, GTK_HAS_GRAB)?
Func to substitute GTK_WIDGET_SET_FLAGS (widget, GTK_HAS_GRAB)?
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.20.x
Other All
: Normal blocker
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 69872
 
 
Reported: 2010-03-31 21:34 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-26 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Introduce _gtk_widget_set_has_grab (2.46 KB, patch)
2010-04-11 21:21 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Introduce _gtk_widget_set_has_grab() interanl function.v2 (2.33 KB, patch)
2010-04-14 12:43 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-03-31 21:34:27 UTC 
This function should be substituted in GTK+ internal code

kalikiana comment:
I think we could go for an internal function like _gtk_widget_set_has_grab
here. It probably isn't something that would/ should be used outside of GTK+.
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-11 21:21:09 UTC 
Created attachment 158452 [details] [review]
Introduce _gtk_widget_set_has_grab
Comment 2 Christian Dywan 2010-04-13 15:51:44 UTC 
Looks good to me.
Comment 3 Emmanuele Bassi (:ebassi) 2010-04-14 12:10:09 UTC 
Review of attachment 158452 [details] [review]:

::: gtk/gtkwidget.c
@@ +5707,3 @@
+                          gboolean   has_grab)
+_gtk_widget_set_has_grab (GtkWidget *widget,
+void

since it's an internal function we could omit the type check here: we control all the callers.
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-14 12:43:15 UTC 
Created attachment 158712 [details] [review]
Introduce _gtk_widget_set_has_grab() interanl function.v2

Updated patch
Comment 5 Emmanuele Bassi (:ebassi) 2010-04-26 18:08:20 UTC 
Review of attachment 158712 [details] [review]:

looks good to me
Comment 6 Javier Jardón (IRC: jjardon) 2010-04-26 19:17:37 UTC 
Comment on attachment 158712 [details] [review]
Introduce _gtk_widget_set_has_grab() interanl function.v2

commit 560e426f16fc5a8a8eaaac2cf6feb85d26e69388
Comment 7 Javier Jardón (IRC: jjardon) 2010-04-26 19:18:06 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks for the reviews.