After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614495 - set|get_extend not working with Cairo::LinearGradient and Cairo::RadialGradient
set|get_extend not working with Cairo::LinearGradient and Cairo::RadialGradient
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Cairo
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-31 17:31 UTC by Quentin Sculo
Modified: 2010-05-16 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.96 KB, patch)
2010-03-31 17:31 UTC, Quentin Sculo 		committed Details | Review

Description Quentin Sculo 2010-03-31 17:31:41 UTC 
Created attachment 157617 [details] [review]
patch

The set|get_extend method is only defined for Cairo::Pattern of type Cairo::ImageSurface instead of for all Cairo::Pattern objects.

patch attached
I've added tests for all Cairo::Pattern subtypes, not sure it's really needed.
Comment 1 Torsten Schoenfeld 2010-03-31 18:17:16 UTC 
The current implementation follows <http://cairographics.org/manual/bindings-patterns.html>.  But it does seem to make sense to call the extend methods on gradient patterns at least.  I've taken this to the cairo list: <http://lists.cairographics.org/archives/cairo/2010-March/019643.html>.  Let's see what they write.
Comment 2 Torsten Schoenfeld 2010-05-16 14:26:40 UTC 
A comment on the list and some more testing confirmed that you are indeed right, and that the manual is wrong.  So committed your patch.  Thanks.

I also treated set_filter and get_filter similarly, for the same reasons.