After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614464 - Encode any ":", "@" or "/" within the user and password field in *_proxy environment
Encode any ":", "@" or "/" within the user and password field in *_proxy envi...
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-31 13:42 UTC by JB Lallement
Modified: 2010-03-31 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
percent encoding of proxy credentials (1.86 KB, patch)
2010-03-31 13:43 UTC, JB Lallement 		needs-work Details | Review

Description JB Lallement 2010-03-31 13:42:19 UTC 
Even if its usage is deprecated, some apps still use auth string in *_proxy environment (e.g http_proxy) 

According to RFC 3986 the user info in an URI must follow the syntax:
userinfo    = *( unreserved / pct-encoded / sub-delims / ":" )

In particular user and password must be percent encoded before being exported.

This issue is reported in Ubuntu https://bugs.edge.launchpad.net/ubuntu/+source/synaptic/+bug/130289 and the attached patch has been proposed against gnome-terminal-2.29.6
Comment 1 JB Lallement 2010-03-31 13:43:31 UTC 
Created attachment 157584 [details] [review]
percent encoding of proxy credentials
Comment 2 Christian Persch 2010-03-31 14:52:36 UTC 
Comment on attachment 157584 [details] [review]
percent encoding of proxy credentials

Patch doesn't apply to master or gnome-2-30, and it leaks memory.
Comment 3 Christian Persch 2010-03-31 14:54:37 UTC 
Also, please use git format-patch when attaching patches. Thanks!
Comment 4 Behdad Esfahbod 2010-03-31 15:03:29 UTC 
Fixed it properly on master.  Please test.