After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614457 - menu tweaks
menu tweaks
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: GNOME3.0
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-31 12:54 UTC by Hylke Bons
Modified: 2010-04-28 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Hylke Bons 2010-03-31 12:54:09 UTC
The HIG specifies to rename the "File" menu to something as specific as possible. "Image" would be a better representation for the use of the program. However, an "Image" menu already exists, which clashes in the menubar, because "File" and "Image" both refer to the same object.

I'd like to suggest to move the actions in the "Image" menu to the "Edit" and "File" menus (plus, this makes it consistent with evince, which has the flip actions in the edit menu too).

Example:

[Image]
  [Open...]
  ---
  [Save]
  [Save As...]
  ---
  [Page Setup]
  [Print...]
  ---
  [Set As Wallpaper]
  ---
  [Properties]
  ---
  [Close]

[Edit]
  [Undo]
  ---
  [Flip Horizontal]
  [Flip Vertical]
  ---
  [Rotate Clockwise]
  [Rotate Counterclockwise]
  ---
  [Move to Trash]
  ---
  [Toolbar]
  [Preferences]

[View]
  ...

[Go]
  ...

[Help]
  ...
Comment 1 Felix Riemann 2010-03-31 18:23:07 UTC
Okay, I can agree on moving the editing stuff to the "Edit" menu.
But I have think a bit about renaming "File" to "Image".
Most people are used to have their "File" menu at the top left (or right), aren't they?
Comment 2 Hylke Bons 2010-03-31 18:33:49 UTC
(In reply to comment #1)

> Most people are used to have their "File" menu at the top left (or right),
> aren't they?

Yes, but it's ok to give it a different name, and it's best to be as specific as possible. Also it's always the most left menu.

A correct use of the word "File" would be in apps like epiphany that can deal with different file types (pages, videos and images, probably more). A lot of apps in GNOME rename this menu already (for example Banshee, Totem, Empathy). The  HIG also suggests this. It gives people using the menu more context.
Comment 3 Allan Day 2010-04-07 13:39:15 UTC
Renaming the file menu is probably the right thing to do (though I'm not sure whether this is actually what the HIG recommends).

The current image menu is rather confusing and should definitely be removed. One question though - since the rotate and flip items don't actually change the file, shouldn't they go in view, rather than edit?
Comment 4 Hylke Bons 2010-04-07 14:06:59 UTC
(In reply to comment #3)
> Renaming the file menu is probably the right thing to do (though I'm not sure
> whether this is actually what the HIG recommends).

I think the HIG needs to more explicitly say this. I talked with Calum about this and he agrees it's not very clear in the HIG, but renaming to be as specific as possible is recommended.

> 
> The current image menu is rather confusing and should definitely be removed.
> One question though - since the rotate and flip items don't actually change the
> file, shouldn't they go in view, rather than edit?

Yes, you are right. Maybe we need to rename them to something sounding less permanent? like "Mirror" and "Upside down" or something?
Comment 5 Hylke Bons 2010-04-07 14:08:04 UTC
> > The current image menu is rather confusing and should definitely be removed.
> > One question though - since the rotate and flip items don't actually change the
> > file, shouldn't they go in view, rather than edit?
> 
> Yes, you are right. Maybe we need to rename them to something sounding less
> permanent? like "Mirror" and "Upside down" or something?

Scrap that, you can actually save in the File menu so they should be in edit.
Comment 6 Allan Day 2010-04-08 09:45:36 UTC
Agreed.
Comment 7 Felix Riemann 2010-04-28 19:05:57 UTC
Okay, let's see how this turns out. :)

commit f55ae89b086d864e0c47af1432fda6d6c8ca42dc
Author: Felix Riemann <>
Date:   Wed Apr 28 20:25:24 2010 +0200

    Reorder menu items to make menus more intuitive and less confusing
    
    Based on a proposal by Hylke Bons. Most visible change is the 'File'
    menu now being more specifically called as 'Image' now as that's what
    we're talking about in this case.
    Also the action names were adjusted to be in line with the others.
    This causes custom toolbars to loose these items on the first start.
    (bug 614457)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.