GNOME Bugzilla – Bug 614388
[POP3] Broken Delete after X days behaviour
Last modified: 2011-03-28 07:28:29 UTC
Initial problem reported here #514827, I can reproduce with latest master build. Messages are removed randomly from server and older messages beyond selected date stacks on pop3. This happens because of cache expiration that is setup to 1 week or 1 day if not visited.
Created attachment 157523 [details] [review] get message_time from pop3 Proposed patch, if we cannot get time from the cache fetch the message from pop3 and calculate message_time.
Another option could be to increase cache age, leaving messages on server and deleting after a few days would pile up a lot of redundant data in the cache. Fetching message from pop is bad enough but perhaps we can do both fetch from pop and increase the cache age too.
Thanks for a patch. I've a feeling there were some issue about the fetching, but I cannot recall what it was exactly. Your change seems good, except of this: > + camel_object_unref((CamelObject *)message); the cast is not necessary, but the test for "message != NULL" is. Apart of that just some small indentation "issues" and a different coding style in your: > + if ( day_lag > days_to_delete) > + { Nothing serious, I would say.
*** Bug 534729 has been marked as a duplicate of this bug. ***
Created attachment 157662 [details] [review] updated patch Thanks Milan, updated patch with your suggestions.
Oh, I'm sorry, I overlooked one thing yesterday, when pop3_get_message fails for some reason, then the message_time is either uninitialized, or the one from the previous message. Please fix this and commit to master and gnome-2-30 branch. Thanks.
Commits: 6fc6243 in e-d-s master (2.31.1+) 64d7416 in e-d-s gnome-2-30 (2.30.1+)
*** Bug 593339 has been marked as a duplicate of this bug. ***
this bug still un-squished in Lucid
(In reply to comment #9) > this bug still un-squished in Lucid Definitely because you've old version of evolution (-data-server). Tell your distro maintainers. The upstream has nothing to do with the distribution you are using.