After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614322 - [id3v2] parse TXXX 'ORIGINAL RELEASE DATE' frame
[id3v2] parse TXXX 'ORIGINAL RELEASE DATE' frame
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-30 05:41 UTC by Carlos Laviola
Modified: 2018-11-03 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Carlos Laviola 2010-03-30 05:41:01 UTC
Bug was cloned as Tim-Philipp Müller's suggestion. Parsing the extended TXXX seems obviously necessary for apps such as Rhythmbox to actually recognize the tags...

+++ This bug was initially created as a clone of Bug #614158 +++

I have found the tags from a number of my MP3 files are not being displaying correctly when they're imported to Rhythmbox. After talking to 'moch' on the #rhythmbox IRC channel, I've been told the following output and file fragment would be helpful in finding out the bug.

Best regards,
Carlos

$ gst-launch-0.10 -t filesrc location=/tmp/example.mp3 \! decodebin \! fakesink
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
FOUND TAG      : found by element "id3demux0".
    track number: 1
      disc count: 1
     disc number: 1
     ID3v2 frame: buffer of 122 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4
                : buffer of 36 bytes, type: application/x-gst-id3v2-talb-frame, version=(int)4
                : buffer of 34 bytes, type: application/x-gst-id3v2-tpe1-frame, version=(int)4
                : buffer of 51 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4
                : buffer of 34 bytes, type: application/x-gst-id3v2-tcom-frame, version=(int)4
                : buffer of 38 bytes, type: application/x-gst-id3v2-tcon-frame, version=(int)4
                : buffer of 63 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4
                : buffer of 28 bytes, type: application/x-gst-id3v2-tpub-frame, version=(int)4
                : buffer of 54 bytes, type: application/x-gst-id3v2-tit2-frame, version=(int)4
                : buffer of 51 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4
                : buffer of 53 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4
container format: ID3 tag
FOUND TAG      : found by element "mpegaudioparse0".
     audio codec: MPEG 1 Audio, Layer 3 (MP3)
FOUND TAG      : found by element "mpegaudioparse0".
         bitrate: 242000
         has crc: FALSE
    channel mode: joint-stereo
FOUND TAG      : found by element "flump3dec0".
     audio codec: MPEG 1 Audio, Layer 3 (MP3)
FOUND TAG      : found by element "flump3dec0".
         bitrate: 128000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 96000
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
FOUND TAG      : found by element "flump3dec0".
         bitrate: 107000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 160000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 179000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 192000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 197000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 209000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 216000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 226000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 225000
FOUND TAG      : found by element "flump3dec0".
         bitrate: 228000
Got EOS from element "pipeline0".
Execution ended after 37089819 ns.
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...
Freeing pipeline ...
Comment 1 Tim-Philipp Müller 2010-03-30 08:37:17 UTC
> Bug was cloned as Tim-Philipp Müller's suggestion. Parsing the extended TXXX
> seems obviously necessary for apps such as Rhythmbox to actually recognize the
> tags...

This is neither obvious nor did I mean to imply that. Could you check my follow-up comment in bug #614158 and confirm whether there are still tags you think we should be extracting but don't? (and if so, which ones?)
Comment 2 Carlos Laviola 2010-03-30 15:15:42 UTC
I didn't mean to say your comment made it sound obvious, but rather the fact that Rhythmbox still doesn't recognize any of the tags even if gst-launch-0.10 will pick some up now.
Comment 3 Carlos Laviola 2010-03-30 15:45:41 UTC
I'm not sure, but from what I'm looking at with an hex editor, it seems like

buffer of 63 bytes, type: application/x-gst-id3v2-txxx-frame, version=(int)4

has the tag with the Year for this song, since it is also in the between TCON and TPUB and contains "ORIGINAL RELEASE DATE 2010".
Comment 4 Tim-Philipp Müller 2010-03-30 23:15:57 UTC
For reference: http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:ID3_Tag_Mapping (sigh). Not sure if this is worthwhile or not, but keeping bug open for now.
Comment 5 Edward Hervey 2013-07-18 05:45:19 UTC
This is handled in the -base tag library now. Moving there.
Comment 6 Edward Hervey 2018-05-05 15:09:24 UTC
Hi Carlo, Can you provide a patch to add that mapping ?
Comment 7 GStreamer system administrator 2018-11-03 11:16:28 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/31.