After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614306 - output-selector, input-selector: move to core
output-selector, input-selector: move to core
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 539042 607513
Blocks:
 
 
Reported: 2010-03-30 00:43 UTC by Brian Cameron
Modified: 2010-12-31 02:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
debug log of failing output selector test (gzipped) (404.34 KB, application/octet-stream)
2010-11-21 22:18 UTC, Tim-Philipp Müller
  Details
improve the test (4.35 KB, patch)
2010-11-24 10:26 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Brian Cameron 2010-03-30 00:43:18 UTC
I notice that due to bug #586356 that a private copy of the selector plugin has already been moved to gst-plugins-base.  Some applications like songbird depend on the selector plugin.  It seems that this plugin should be fully integrated.  What work, if any, is still needed?  I don't see any bugs filed about this already.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-08-24 07:54:46 UTC
I think this should be moved to core. The two elements are media agnostic and we have a copy in gst-plugin-base for playbin2 right now.

The elements have docs and a few unit tests. I have pending patches for code cleanups (use BOILERPLATE macros).
Comment 2 Sebastian Dröge (slomo) 2010-08-24 08:06:02 UTC
Wim, you said some time ago, that input-selector is more or less ready but that there are some things in output-selector that need to be changed. Do you remember details?
Comment 3 Tim-Philipp Müller 2010-10-11 11:48:15 UTC
-bad/tests/icles/output-selector-test just errors out with not-negotiated for me, that should be fixed.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-19 15:40:35 UTC
Works fine for me. I'll try this on a few different machines as well. Tim, if you could attach a debug log.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-21 10:52:22 UTC
Also tried at home with same result - works as expected. The systems are:
intel core duo under ubuntu 10.04
amd phenon II X6 under opensuse 11.3

I'll try in on my netbook in the coming days as well.
Comment 6 Tim-Philipp Müller 2010-11-21 22:18:40 UTC
Created attachment 174996 [details]
debug log of failing output selector test (gzipped)
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-23 10:12:29 UTC
Can you run two xvimagesinks? The example hardcodes this :/

gst-launch v4l2src ! video/x-raw-yuv,width=320,height=240 ! tee name=t ! queue ! xvimagesink t. ! queue ! xvimagesink

gst-launch v4l2src ! video/x-raw-yuv,width=320,height=240 ! timeoverlay ! tee name=t ! queue ! xvimagesink t. ! queue ! xvimagesink
Comment 8 Tim-Philipp Müller 2010-11-23 10:21:34 UTC
Yes, those pipelines work fine here (if I couldn't run two xvimagesinks it would fail with an appropriate error and not not-negotiated).
Comment 9 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-24 10:26:18 UTC
Created attachment 175152 [details] [review]
improve the test

Tim, this is some test cleanup. According to you log videotestsrc and timeoverlay have issues negotiating the the same format, which is a bit weired as they are pure software and for me they negotiate fine. The attached patch adds a ffmpegcolorspace there and also uses autovideosinks instead of hardcoded sinks. Do these changes make it work?
Comment 10 Tim-Philipp Müller 2010-12-08 15:47:52 UTC
> Tim, this is some test cleanup

That makes it work, thanks!
Comment 11 Tim-Philipp Müller 2010-12-31 02:04:21 UTC
Wim said on IRC he was fine with these moving as well, so moved to core, removed from -bad.