GNOME Bugzilla – Bug 614250
Clicking on desktop under Metacity does not hide stickynotes
Last modified: 2010-07-27 19:33:10 UTC
Created attachment 157379 [details] [review] Make desktop-click-hiding work again; add pref. to control this. At least with 2.28, almost certainly later versions, and possibly with earlier versions, clicking on the desktop no longer hides all stickynotes as it used to. Notes can still be toggled by clicking on the applet's icon. It does work however, under openbox and (so I've been told compiz). The reason is due to sickynotes monitoring the _NET_WM_USER_TIME property off the main desktop window to be told when the user has clinked on it. Metacity now appears to use the extended functionality of this property, whereby one sets _NET_WM_USER_TIME_WINDOW on the main window to be the window ID that contains the _NET_WM_USER_TIME that should be monitored, a level of indirection that stickynotes does not follow. I have implemented a patch that fixes this on my box (Fedora 12, using GNOME 2.28), and will attach it. I have taken the liberty of implementing a new preference that allows one to disable this desktop-selection-hides-the-notes functionality, as (somewhat ironically) I personally (and others) don't like it. Hopefully, that can be incorporated as well. As I patched against my own local copy, this patch presumes the inclusion of my bugfix patch from bug 601908 for stickynotes.ui (the one that fixes the title-bar context menu).
Review of attachment 157379 [details] [review]: Very nice! I tested your patch in current Ubuntu Lucid (beta) and it works as expected. I missed this feature and joined the discussions about re-implementing it. Your patch is a good compromise with the checkbox to turn the feature on or off. I'd suggest to describe the checkbox "Hide notes when des_ktop background is clicked" (read *BACKGROUND*).
Review of attachment 157379 [details] [review]: Actually, I'm missing a "the" as well; I'll upload a new copy with that fixed, but I'm not sure about the "background" bit; at least on my box, the stickynotes are also hidden when /icons/ on the desktop are selected, not just the background. I also found that global key-bindings (in openbox, anyway) and mouse-wheel clicks (changes desktop in OB) do it, so it's not necessarily just desktop-background interaction that hides the notes.
Created attachment 158262 [details] [review] Make desktop-click-hiding work again; add pref. to control this. Typo. fix: missing "the" in help text.
Review of attachment 158262 [details] [review]: I see, you're right - forget the *BACKGROUND*. I checked the diff of this patch to your previous one and I think we can mark it as reviewed now. (I hope it's ok that I did this, although I am quite new to Gnome code)
It's been two months since the patch was reviewed. Can someone please integrate it? I'd hate to see Neil's work go to bitrot.
Neil, go ahead and commit. Just remember that we are in a string/ui announce period. Quoting the schedule: "String Change Announcement Period: All string changes must be announced to both gnome-i18n@ and gnome-doc-list@. UI Change Announcement Period: All user interface changes must be announced to gnome-doc-list@." Check the archives for the typical format.
Patch committed to git master.
*** Bug 510933 has been marked as a duplicate of this bug. ***