After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614215 - Use symbolic icons for applet
Use symbolic icons for applet
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: applets
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks: 614211
 
 
Reported: 2010-03-29 04:20 UTC by William Jon McCann
Modified: 2010-06-10 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description William Jon McCann 2010-03-29 04:20:05 UTC
The battery "applet" should use the new low color symbolic icons.  The only
change that should be needed is to append the string "-symbolic" to the
requested icon name.

All system status indicators should be moving to this design.
Comment 1 William Jon McCann 2010-03-29 04:20:58 UTC
Actually, that isn't quite true.  We'll need to modify the names of the icons used and some of the logic too.
Comment 2 William Jon McCann 2010-03-29 05:06:45 UTC
Currently the theme only has the following icons:
battery-critical-charging-symbolic.svg
battery-critical-symbolic.svg
battery-full-charging-symbolic.svg
battery-full-symbolic.svg
battery-good-charging-symbolic.svg
battery-good-symbolic.svg
battery-low-charging-symbolic.svg
battery-low-symbolic.svg
battery-missing-symbolic.svg
Comment 3 Richard Hughes 2010-03-29 07:48:26 UTC
(In reply to comment #0)
> All system status indicators should be moving to this design.

Is this something that has been decreed in the HIG? If so, I'll need to generate way more icons for g-p-m to use. How come there's a -symbolic suffix? Is there a requirement to keep the old non-symbolic icons?
Comment 4 William Jon McCann 2010-03-29 15:41:14 UTC
We haven't written up formal guidelines yet.  Some info here: http://www.freedesktop.org/wiki/SymbolicIcons

You can find the icons in git in gnome-icon-theme-symbolic.
Comment 5 Richard Hughes 2010-03-30 08:51:17 UTC
(In reply to comment #2)
> Currently the theme only has the following icons:
> battery-critical-charging-symbolic.svg
> battery-critical-symbolic.svg
> battery-full-charging-symbolic.svg
> battery-full-symbolic.svg
> battery-good-charging-symbolic.svg
> battery-good-symbolic.svg
> battery-low-charging-symbolic.svg
> battery-low-symbolic.svg
> battery-missing-symbolic.svg

I think some people are going to be upset but the lack of precision in the icon. The old range had 7 steps, and the new range seems to have 4 steps. I'm not that bothered, but quite a few people want more steps, not less. There is also the problem as you seem to be equating charging with charged, but this really isn't the same thing. There's also no empty state either.

In the old scheme things went like this (charging):

gpm-battery-020
gpm-battery-000
gpm-battery-empty
(insert power adapter)
gpm-battery-000-charging
gpm-battery-020-charging
gpm-battery-040-charging
gpm-battery-060-charging
gpm-battery-080-charging
gpm-battery-100-charging
gpm-battery-charged

The new scheme seems to go:

battery-low
battery-critical
(insert power adapter)
battery-critical-charging
battery-low-charging
battery-good-charging
battery-full-charging

So you never see when the battery is charged or when the battery is empty (think multiple batteries in one laptop). This matters a lot to some people, as they might be charging multiple batteries or might want to remove the battery when it gets to 100% charged and is no longer charging to preserve battery lifetime.
Comment 6 Richard Hughes 2010-06-10 13:51:48 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.