After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614212 - Use symbolic icons for applet
Use symbolic icons for applet
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on: 621175
Blocks: 614211
 
 
Reported: 2010-03-29 04:13 UTC by William Jon McCann
Modified: 2010-06-10 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1022 bytes, patch)
2010-03-29 04:40 UTC, William Jon McCann
none Details | Review

Description William Jon McCann 2010-03-29 04:13:56 UTC
The volume control "applet" should use the low color symbolic icons.  The only change that should be needed is to append the string "-symbolic" to the requested icon name.
Comment 1 William Jon McCann 2010-03-29 04:40:04 UTC
Created attachment 157349 [details] [review]
patch
Comment 2 Marc-Andre Lureau 2010-06-08 22:58:07 UTC
Hi

+        "audio-input-microphone-muted-symbolic",
+        "audio-input-microphone-low-symbolic",
+        "audio-input-microphone-medium-symbolic",
+        "audio-input-microphone-high-symbolic",

I have only:

audio-input-microphone-symbolic

And the other icons do not seem to be available:
http://git.gnome.org/browse/gnome-icon-theme-symbolic/tree/gnome/scalable/devices

Also, it works, but only with gnome-settings-daemon running (on my debian).

is there a fallback mechanism we could use to still have gtk icons if the symbolic theme cannot be loaded?

thanks
Comment 3 Bastien Nocera 2010-06-08 23:47:06 UTC
(In reply to comment #2)
> Hi
> 
> +        "audio-input-microphone-muted-symbolic",
> +        "audio-input-microphone-low-symbolic",
> +        "audio-input-microphone-medium-symbolic",
> +        "audio-input-microphone-high-symbolic",
> 
> I have only:
> 
> audio-input-microphone-symbolic
> 
> And the other icons do not seem to be available:
> http://git.gnome.org/browse/gnome-icon-theme-symbolic/tree/gnome/scalable/devices

Need to file another bug.

> Also, it works, but only with gnome-settings-daemon running (on my debian).
> 
> is there a fallback mechanism we could use to still have gtk icons if the
> symbolic theme cannot be loaded?

It doesn't work usefully without GTK+ 3.0, and a tray with support for the symbolic colours.
Comment 4 Marc-Andre Lureau 2010-06-10 23:22:25 UTC
and committed

commit 735635b3fa7e9c1aa6d4e34f9a56b6b59cddcf7e
Author: William Jon McCann <jmccann@redhat.com>
Date:   Thu Jun 10 22:11:29 2010 +0200

    g-v-c: use symbolic icons

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.