After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614202 - access key does not work in time-admin
access key does not work in time-admin
Status: RESOLVED WONTFIX
Product: gnome-system-tools
Classification: Deprecated
Component: time-admin
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: system-tools-maint
system-tools-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-03-28 21:50 UTC by Victor Vargas
Modified: 2012-11-24 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
D (1.35 KB, patch)
2010-04-14 08:29 UTC, Xiegai Shan
needs-work Details | Review
Patch Updated - Configuration now uses "Alt + g", Time Label uses "Alt + T" (1.35 KB, patch)
2010-04-14 20:00 UTC, Xiegai Shan
reviewed Details | Review

Description Victor Vargas 2010-03-28 21:50:25 UTC
This report was originally filed at:
https://bugs.edge.launchpad.net/ubuntu/+source/gnome-system-tools/+bug/287262



To reproduce this bug run time-admin from a terminal.
Then press "Alt+C" to push the "Close" button and to close the application.
Nothing happens.
In the terminal the following warning appears:
(time-admin:9236): Gtk-WARNING **: Couldn't find a target for a mnemonic activation.

I think this happens because "Alt+C" access key is bound to two different actions: "Close" and "Configuration".
Comment 1 Milan Bouchet-Valat 2010-03-29 13:56:21 UTC
Confirmed. Should be easy to fix.
Comment 2 Xiegai Shan 2010-04-14 08:29:38 UTC
Created attachment 158695 [details] [review]
D
Comment 3 Xiegai Shan 2010-04-14 08:32:20 UTC
Sorry, the patch above fixed some Mnemonic settings on 2 labels.

1. Change the labe from "Configuration" to "Sync Configuration"
2. Add mnemonic widget on "Time" Label.
Comment 4 Milan Bouchet-Valat 2010-04-14 11:07:31 UTC
No need to add a word to the label. Just choose a random letter in the existing label. For example, "Confi_guration".
Comment 5 Xiegai Shan 2010-04-14 20:00:32 UTC
Created attachment 158752 [details] [review]
Patch Updated - Configuration now uses "Alt + g", Time Label uses "Alt + T"

Patch Updated - Configuration now uses "Alt + g", Time Label uses "Alt + T"
Comment 6 Milan Bouchet-Valat 2010-04-14 20:52:34 UTC
Review of attachment 158752 [details] [review]:

I'm curious why the patch adds two lines about mnemonic widgets. These lines should have been present already, else the mnemonic wouln't have worked. So either I'm missing something, or you can just remove those two changes, which gives you a one-line patch!
Comment 7 Xiegai Shan 2010-04-14 21:30:30 UTC
(In reply to comment #6)
> Review of attachment 158752 [details] [review]:
> 
> I'm curious why the patch adds two lines about mnemonic widgets. These lines
> should have been present already, else the mnemonic wouln't have worked. So
> either I'm missing something, or you can just remove those two changes, which
> gives you a one-line patch!

The first mnemonic is for the "Configuration"
The second mnemonic is for the "Time" (this one didn't work either because no mnemonic is set)
Comment 8 Milan Bouchet-Valat 2010-04-15 08:45:05 UTC
Ah, good catch indeed! So this completely useless mnemonic was preventing the Close button from being activated...

If you provide a formatted patch with a title and description, I'll commit it ASAP.

Note that if you wish this patch to be applied to the stable 2.30.x series, you'd have to update the translations too by running:
sed -i -e "s/_Configuration:/Confi_guration/g" *.po
from the po/ dir of the source tree, and add the changes to the patch too. This will ensure we don't break translations.
Comment 9 André Klapper 2012-11-24 20:28:16 UTC
According to its developer(s), gnome-system-tools is not under active development anymore. Functionality has been mostly integrated into GNOME Control Center / "[System] Settings".

It is unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping - Please feel
free to reopen this bug report in the future if anyone takes the responsibility
for active development again.