After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614164 - Add ref/unref functions to GValueArray
Add ref/unref functions to GValueArray
Status: RESOLVED WONTFIX
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-03-28 10:36 UTC by Sebastian Dröge (slomo)
Modified: 2012-02-27 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add g_value_array_ref() and g_value_array_unref() functions (7.34 KB, patch)
2010-03-28 10:36 UTC, Sebastian Dröge (slomo) 		none Details | Review
Add g_value_array_ref() and g_value_array_unref() functions (7.42 KB, patch)
2010-03-28 10:42 UTC, Sebastian Dröge (slomo) 		none Details | Review
Use ref/unref functions of GValueArray for the boxed type (850 bytes, patch)
2010-03-28 10:45 UTC, Sebastian Dröge (slomo) 		none Details | Review

Description Sebastian Dröge (slomo) 2010-03-28 10:36:11 UTC 
Hi,
attached patch adds ref/unref functions to GValueArray. The approach taken is the same as for GArray and friends.
Comment 1 Sebastian Dröge (slomo) 2010-03-28 10:36:37 UTC 
Created attachment 157315 [details] [review]
Add g_value_array_ref() and g_value_array_unref() functions
Comment 2 Sebastian Dröge (slomo) 2010-03-28 10:42:25 UTC 
Created attachment 157316 [details] [review]
Add g_value_array_ref() and g_value_array_unref() functions
Comment 3 Sebastian Dröge (slomo) 2010-03-28 10:45:35 UTC 
Created attachment 157318 [details] [review]
Use ref/unref functions of GValueArray for the boxed type
Comment 4 Sebastian Dröge (slomo) 2010-03-28 10:46:57 UTC 
(In reply to comment #3)
> Created an attachment (id=157318) [details] [review]
> Use ref/unref functions of GValueArray for the boxed type

Not sure if this is an API change (because you now get refs instead of copies) but it prevents copying of the complete array in some places. Maybe this one should wait until GLib 3.0 :)
Comment 5 Sebastian Dröge (slomo) 2010-05-16 18:08:34 UTC 
Can we get the patch for adding the functions in at least?
Comment 6 Sebastian Dröge (slomo) 2011-03-26 10:39:50 UTC 
Any chance we can get the first patch (that only adds the functions and nothing else) pushed now?
Comment 7 Matthias Clasen 2012-02-27 03:38:51 UTC 
since we're deprecating GValueArray, this won't land