After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614159 - Timeformat string marked for translation is not localizable
Timeformat string marked for translation is not localizable
Status: VERIFIED DUPLICATE of bug 613306
Product: gdm
Classification: Core
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-28 09:18 UTC by TLE
Modified: 2010-03-29 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description TLE 2010-03-28 09:18:39 UTC 
Hallo gdm-devs

I wanted to translate the following string:

#. translators: This is the time format to use for the date
#.
#: ../gui/simple-greeter/gdm-clock-widget.c:87
#: ../gui/simple-greeter/gdm-clock-widget.c:94
#, c-format
msgid "%x"

So I figure that it was a strftime type string, so I checked out the format for %x and figured that for Danish it should be:

"%d/%m-%y"

but when I do that it does not pass msgfmt check that says:

gdm.master.da.po:595: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: In the directive number 3, the character 'y' is not a valid conversion specifier.

and hence I can't commit.

Regards Kenneth Nielsen
Comment 1 Takao Fujiwara 2010-03-29 02:30:43 UTC 
I think %x is not a translatable string.
I think the msgstr is also "%x" so that LC_TIME can change the value instead of LC_MESSAGES.

Thanks
Comment 2 Claude Paroz 2010-03-29 06:51:22 UTC 

*** This bug has been marked as a duplicate of bug 613306 ***
Comment 3 TLE 2010-03-29 09:17:17 UTC 
(In reply to comment #1)
> I think %x is not a translatable string.
> I think the msgstr is also "%x" so that LC_TIME can change the value instead of
> LC_MESSAGES.
> 
> Thanks

If it is not supposed to be a translatable string, then don't mark it for translation.
Comment 4 Ray Strode [halfline] 2010-03-29 18:07:00 UTC 
It's fine to translate the string.  I even have a translator comment:


/* translators: This is the time format to use for the date
 */

I guess the msgfmt check thinks the string is a printf string.  Not sure.
Comment 5 Ray Strode [halfline] 2010-03-29 18:38:09 UTC 
okay thinking about this more, I agree with Takao, it shouldn't be marked for translation.

If %x doesn't expand to %d/%m-%y for danish locales, we should probably fix glibc.