After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614137 - Menu set_screen() allow NULL
Menu set_screen() allow NULL
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-27 23:04 UTC by Kevin Ryde
Modified: 2010-03-31 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GdkScreen_ornull for gtk_menu_set_screen() (281 bytes, patch)
2010-03-27 23:04 UTC, Kevin Ryde 		committed Details | Review
GtkMenu.t test case (304 bytes, patch)
2010-03-27 23:07 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-03-27 23:04:50 UTC 
Created attachment 157292 [details] [review]
GdkScreen_ornull for gtk_menu_set_screen()

I believe gtk_menu_set_screen() accepts NULL, but the wrapper doesn't allow that.

Have I whinged about the tedium of manually wrapped set funcs lately :-)

-- 
"Is it about the hedge?"
Comment 1 Kevin Ryde 2010-03-27 23:07:04 UTC 
Created attachment 157293 [details] [review]
GtkMenu.t test case

forget the test to exercise it
Comment 2 muppet 2010-03-27 23:56:01 UTC 
Review of attachment 157292 [details] [review]:

Looks good to me.
Comment 3 muppet 2010-03-27 23:56:13 UTC 
Review of attachment 157293 [details] [review]:

Also good.

This patch review interface needs a "Ship It!" button like review board.
Comment 4 Torsten Schoenfeld 2010-03-31 17:38:18 UTC 
Both committed, thanks.