After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614103 - gedit Word Completion Plugin: configure the number of characters to display dialog
gedit Word Completion Plugin: configure the number of characters to display d...
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-27 15:38 UTC by Jean-Philippe Fleury
Modified: 2019-03-23 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
word completion: add configure options (16.65 KB, patch)
2013-06-10 11:26 UTC, Sébastien Wilmet
accepted-commit_now Details | Review

Description Jean-Philippe Fleury 2010-03-27 15:38:20 UTC
It would be very useful to be able to set the number of characters needed to display the completion dialog. By default, after only 2 characters, the dialog appears. I would like to be able to set this number to 4 characters, so the dialog would not appear constantly.
Comment 1 Jean-Philippe Fleury 2010-03-27 15:43:04 UTC
"so the dialog would not appear constantly": I mean that when we use gedit to enter text, there are a lot of little words. For example:

>L'été s'en va et l'hiver s'en vient.

In this sentence, only 2 words have at least 4 characters.
Comment 2 jessevdk@gmail.com 2010-03-28 11:45:03 UTC
Ok, there are two different things that can be configured here. 1) the minimal word length needed for finding words in the document and adding them to the list of completion words. 2) after how many characters the interactive completion should start.

Which one do you mean to be configurable? With regard to implementation, these things are already managed as properties, so it would be a matter of providing an UI for it (and storing/restoring from gconf)
Comment 3 Jean-Philippe Fleury 2010-03-28 14:04:53 UTC
Hi,

I mean after how many characters the interactive completion should start.

Regards,

Jean-Philippe
Comment 4 Sébastien Wilmet 2013-06-10 11:25:55 UTC
Currently the minimum word size (for scanning the words in the buffer) is also used for triggering the interactive completion.

I'll attach a patch to add two configuration options, one for this bug, and the other option for bug #648946.

The patch needs the commit at:
https://git.gnome.org/browse/gtksourceview/commit/?h=wip/word-completion
Comment 5 Sébastien Wilmet 2013-06-10 11:26:43 UTC
Created attachment 246395 [details] [review]
word completion: add configure options

- minimum word size
- whether to enable interactive completion
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-06-10 16:35:01 UTC
Review of attachment 246395 [details] [review]:

Looks good to me.
Comment 7 Sébastien Wilmet 2013-06-10 17:26:23 UTC
Thanks for the prompt review. The commits are pushed.