After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614065 - Banshee is only importing certain files
Banshee is only importing certain files
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
1.5.6
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-26 23:41 UTC by Severo Raz
Modified: 2010-04-01 04:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Debug output of importing action (9.51 KB, text/plain)
2010-03-26 23:41 UTC, Severo Raz
  Details
debug patch (906 bytes, patch)
2010-03-29 22:50 UTC, Alexander Kojevnikov
none Details | Review

Description Severo Raz 2010-03-26 23:41:42 UTC
Created attachment 157234 [details]
Debug output of importing action

Attached you will find the [$ banshee --debug] output of the error when I try to import music from my main folder, which is located in a ntfs partition I have symlinked to my home folder--ext3.

Of the ~2,000 songs I have, I can only import and listen to 92 of them. The protocol banshee is following to import or discard a music file, is unknown by me.
Comment 1 Gabriel Burt 2010-03-26 23:44:27 UTC
From the log, looks like this might be the culprit:

[Warn  17:27:00.587] Caught an exception - System.InvalidOperationException: Path doesn't exist! (in `Mono.Posix')
  at Mono.Unix.UnixFileSystemInfo.AssertValid () [0x00000] 
  at Mono.Unix.UnixFileSystemInfo.get_IsSymbolicLink () [0x00000] 
  at Banshee.IO.Unix.Directory.TraverseSymlink (Mono.Unix.UnixFileSystemInfo info) [0x00000] 
  at Banshee.IO.Unix.Directory+<GetDirectories>c__Iterator1.MoveNext () [0x00000] 
  at Banshee.IO.DirectoryScannerPipelineElement.ScanForFiles (System.String source, Boolean skip_hidden) [0x00000]
Comment 2 Gabriel Burt 2010-03-26 23:45:18 UTC
Wolter, is the top-level folder you're trying to import the symlink to your NFS share?
Comment 3 Gabriel Burt 2010-03-26 23:46:41 UTC
Oh, just realized.  Is it importing some of your files under this symlink/on the NFS share, but just not most of them?  That would be quite bizarre, and not what I was thinking.
Comment 4 Gabriel Burt 2010-03-26 23:49:48 UTC
If you could get Banshee building from source so you could test some patches, that would be very helpful!  Here are some instructions: http://banshee-project.org/download/development/
Comment 5 Severo Raz 2010-03-27 02:26:55 UTC
Well, I'll try to find some time to do it. Just wanted to remind you that it is not an NFS share, its an NTFS (Windows' file system) partition. I hope I don't have to download many dependencies.
Comment 6 Severo Raz 2010-03-27 03:10:01 UTC
I'm ready for patches.
Comment 7 Alexander Kojevnikov 2010-03-29 22:50:21 UTC
Created attachment 157421 [details] [review]
debug patch

Wolter, could you apply the attached patch, then compile, run, import the files and attach the log.

Please ping me on IRC if you have problems applying or compiling, my nick is alexk.
Comment 8 Alexander Kojevnikov 2010-03-30 00:25:42 UTC
It was a broken symlink. Committed a fix which checks for those.

commit 6243e79385970abe6c3f04e9c826b5836b56e52c
Author: Alexander Kojevnikov <alexander@kojevnikov.com>
Date:   Tue Mar 30 11:20:57 2010 +1100

    [IO.Unix] Check for broken symlinks (bgo#614065)
Comment 9 Severo Raz 2010-03-30 06:38:38 UTC
Thanks for the fix Alex, wonderful find and work.
Comment 10 Mike 2010-03-31 23:28:35 UTC
For others suffering from this bug, the following will help you find the broken link:

for i in `find <DIRNAME> -type l`; do [ -e $i ] || echo $i is broken; done

Just change DIRNAME to your music directory, and you should be all set.
Comment 11 Severo Raz 2010-04-01 04:57:54 UTC
Nice script Mike