GNOME Bugzilla – Bug 613980
StButton supposes a ClutterText label
Last modified: 2010-04-09 14:53:43 UTC
Created attachment 157129 [details] [review] StButton supporting StLabel as text object StButton is a button with supports a text label or icon. For the label it supposes a ClutterText object. Anyway gnome-shell is using StLabel as the text object in some cases, like the activities button, so some functions, like st_button_update_label_style just return without doing anything on the text. Options: 1.) The error is in StButton: Fix StButton, so a StLabel is also valid as text object (straighforward patch attached) 2.) The error is use StLabel on StButton: check the UI, and use ClutterText instead Of course there is other option, that the StLabel was being used as a icon object here, but at first it seems really unlikely (IMHO)
Can you describe more exactly what symptom you are trying to fix? In the case where the child of a StButton is a StLabel - where it is created explicitly by the application - I'd expect the text style on the child to be the relevant style, not the text style on the button.
(In reply to comment #1) > Can you describe more exactly what symptom you are trying to fix? I didn't found any visual symptom, it was something that shocked me after a quick review of the code. > In the case where the child of a StButton is a StLabel - where it is created > explicitly by the application - I'd expect the text style on the child to be > the relevant style, not the text style on the button. Well, I expected the opposite, I mean, if the StButton has a text style, and you introduce a text-related object inside, the correct style of the child should be the button one. After all, if you want a specific style on the text of the button, you could set up the style in the button. But after thinking it a little, I think that you are right, and my option is confusing, less flexible and could create some problems. In the same way, it is strange to start to check the type of the inner object to check if it makes sense to sync the style, and somewhat hardcoded. The current approach is more simple and clear, set the style if you have just a ClutterText, and let custom (and themable) children (created by the application) manage his own style. So, feel free to mark this bug as INVALID. Sorry for the noise.
Remember also that font and color are inherited. If font and color aren't specified on the StLabel, it will use the font and color of the parent StButton. (It would be cleaner perhaps if StButton always had a StLabel child and we got rid of st_button_update_label_style(), but don't want to make that change at the moment. And it would mean more actors and be a bit less efficient.)