Bug 613956 - Glade should use GtkToolPalette internally
Glade should use GtkToolPalette internally
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Tristan Van Berkom
Glade 3 Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-03-25 20:47 UTC by Tristan Van Berkom
Modified: 2010-03-27 11:19 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to integrate the toolpalette (20.77 KB, patch)
2010-03-25 20:52 UTC, Tristan Van Berkom 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Tristan Van Berkom 2010-03-25 20:47:56 UTC 
I thought there was an old bug for this bug I cant find it on the list
any longer.

Opening this temporarily as a marker, about to get rid of a lot of internal
code in favor of the GtkToolPalette.
Comment 1 Tristan Van Berkom 2010-03-25 20:52:39 UTC 
Created attachment 157109 [details] [review]
Patch to integrate the toolpalette

This patch integrates the GtkToolPalette as an internal member of
the Glade palette without breaking any api or introducing any regressions
as far as I can see.

The Glade palette still serves as an api and implements the scrolled window
and some optional buttons that are part of its api (used by Anjuta);

This patch allows removal of the:
   glade-palette-box.[ch]
   glade-palette-expander.[ch]
   glade-palette-item.[ch]
Comment 2 Tristan Van Berkom 2010-03-25 21:22:57 UTC 
Glade (git master) now uses GtkToolPalette with no regressions
so far:
  - CNTL-click for "sticky selections" still works
  - Project warnings work (i.e. deprecated widgets and widgets available only
    in target project version's future)
  - Context menu works: Note, GtkToolPalette should be improved to let you do
    context menus as the toolbar does, currently we have to connect to the
    internal child button of a GtkToolButton to do context menus.
Comment 3 Murray Cumming 2010-03-27 11:19:25 UTC 
Please file a bug about the need for context-menu API in GtkToolPalette.
Note You need to log in before you can comment on or make changes to this bug.