After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613932 - notifications: make whole area clickable
notifications: make whole area clickable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marina Zhurakhinskaya
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-25 17:27 UTC by Hylke Bons
Modified: 2010-07-27 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[notifications] Make the whole notification clickable (1.97 KB, patch)
2010-06-13 14:27 UTC, Florian Müllner
needs-work Details | Review
[notifications] Make the whole notification clickable (2.10 KB, patch)
2010-07-21 11:31 UTC, Florian Müllner
none Details | Review
[notifications] Make the whole notification clickable (2.14 KB, patch)
2010-07-21 14:25 UTC, Florian Müllner
committed Details | Review

Description Hylke Bons 2010-03-25 17:27:08 UTC
The notifications feature is very nice, only, I spent a week wondering why i couldn't click on it to go to the activity. Turns out I can only click the icon. This is very unclear. It's a very small hit target as well.

Suggestion: make the whole notification clickable.
Comment 1 Florian Müllner 2010-06-13 14:27:23 UTC
Created attachment 163510 [details] [review]
[notifications] Make the whole notification clickable

It is not obvious that only the icon is clickable to activate the
default action - in fact, with the area being that tiny, many don't
even know that notifications can be clicked.
Just extend the clickable area to the whole notification.
Comment 2 Marina Zhurakhinskaya 2010-07-21 07:13:32 UTC
Review of attachment 163510 [details] [review]:

We definitely want this behavior, but the patch needs to be updated to not open the Empathy chat when the chat box entry is clicked. I tested it for when you click on the notification actions, and it doesn't open the application in that case, which is right.
Comment 3 Florian Müllner 2010-07-21 11:31:42 UTC
Created attachment 166268 [details] [review]
[notifications] Make the whole notification clickable

(In reply to comment #2)
> We definitely want this behavior, but the patch needs to be updated to not open
> the Empathy chat when the chat box entry is clicked.

Good point. Updated patch to generally exclude the action area.
Comment 4 Florian Müllner 2010-07-21 14:25:28 UTC
Created attachment 166287 [details] [review]
[notifications] Make the whole notification clickable

Gah - shouldn't update patches with my head elsewhere ... fixed.
Comment 5 Dan Winship 2010-07-27 11:08:00 UTC
Comment on attachment 166287 [details] [review]
[notifications] Make the whole notification clickable

looks good
Comment 6 Florian Müllner 2010-07-27 11:18:15 UTC
Attachment 166287 [details] pushed as e287aa1 - [notifications] Make the whole notification clickable