GNOME Bugzilla – Bug 613917
add support for buildbot 0.7.12
Last modified: 2010-06-11 18:29:13 UTC
At least {{{jbhuild.commands.bot.cmd_bot.JhBuildMaster.loadConfig()}}} needs to be synced with the upstream source as it has been copied verbatim. I've set the severity to critical as it doesn't work with 0.7.11p3 either and buildbot versions before that [http://buildbot.net/trac/wiki/SecurityAlert0711 are vulnerable] to several XSS attacks.
Created attachment 157063 [details] [review] JhBuildMaster.loadConfig(): sync code with upstream (buildbot-0.7.12) Please review and test before applying. It allows the buildbot to start without errors, but no further testing has been done (yet).
Created attachment 157066 [details] [review] remove JhStatusResourceBuilder.body() I don't know what the original intent of overriding body() was, but it's broken now and removing it shows no negative effects so far. Links seem to be working fine.
Created attachment 157081 [details] [review] remove JhStatusResourceBuild.body() Like for JhStatusResourceBuilder.body() I don't know why JhStatusResourceBuild.body() was introduced, but simply removing it seems to work fine so far.
I've been using all 3 patches. And it works with buildbog 0.7.12 perfectly fine. Patches are correct IMHO. I've put it on gitorious so I can easily use it. Use this to pull these three patches: git pull git://gitorious.org/~xnox/jhbuild/jhbuild-mirror.git refs/merge-requests/2 Thanks.
JhStatusResourceBuilder.body() handles http://build.gnome.org/builders/gnome-common-bxlug-sid JhStatusResourceBuild.body() handles http://build.gnome.org/builders/gnome-common-bxlug-sid/builds/816 Could you check those pages are still working properly with your patches?
Sascha, I don't know what kind of error you had with those body(), I (finally!) had time to look and the related pages were working fine, so I left them in and pushed your initial commit, and another. Thanks, and sorry for being so slow. commit 7bfb89dce3adc3e3d9b49b790a2c8ecd61ff989c Author: Frédéric Péters <fpeters@0d.be> Date: Fri Jun 11 20:21:05 2010 +0200 [buildbot] update buildbot version to 0.7.12 (GNOME bug 613917) commit 43801d70412e7916a3a232df80021f7de7c106e2 Author: Sascha Silbe <sascha-pgp@silbe.org> Date: Thu Mar 25 14:45:32 2010 +0000 JhBuildMaster.loadConfig(): sync code with upstream (buildbot-0.7.12)