After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613884 - Clicking on a notebook name has no effect
Clicking on a notebook name has no effect
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: general
git master
Other Linux
: Normal normal
: 1.0 (public beta)
Assigned To: snowy-maint
snowy-maint
Depends on: 612025
Blocks:
 
 
Reported: 2010-03-25 08:46 UTC by Sandy Armstrong
Modified: 2011-01-18 05:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Clicking a notebook name works now (3.75 KB, patch)
2010-12-23 16:55 UTC, Jeff Schroeder
none Details | Review
v2 (3.79 KB, patch)
2010-12-27 06:23 UTC, Jeff Schroeder
none Details | Review
Version 3 to make clicking notebook names in the sidebar work (3.79 KB, patch)
2011-01-18 03:31 UTC, Jeff Schroeder
committed Details | Review

Description Sandy Armstrong 2010-03-25 08:46:47 UTC
When clicking a notebook name on the sidebar, you should somehow be taken to a view of the notes in that notebook.

We have discussed doing this inline in the sidebar, or simply forwarding the user to a search page with "notebook:my-notebook-name" as the query (this would, of course, imply that we would add keys like "notebook" to the search form).

Ideas and patches welcome.
Comment 1 Jeff Schroeder 2010-12-23 16:55:39 UTC
Created attachment 176950 [details] [review]
Clicking a notebook name works now
Comment 2 Jeff Schroeder 2010-12-27 06:23:23 UTC
Created attachment 177083 [details] [review]
v2

Version 2:
    - Sorts notes in descending order by modified date
    - Uses the patch in https://bugzilla.gnome.org/show_bug.cgi?id=612025 to hide template notes.
Comment 3 Jeff Schroeder 2011-01-18 03:31:53 UTC
Created attachment 178579 [details] [review]
Version 3 to make clicking notebook names in the sidebar work

Version 3:
    - Translate "All Notes for"
    - Update the invocation of Note.objects.user_viewable to not use templates=False. It is the default in the merged patch.
Comment 4 Sandy Armstrong 2011-01-18 04:59:28 UTC
Review of attachment 178579 [details] [review]:

Looks good!