After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613875 - Does not react to gvfs media changes
Does not react to gvfs media changes
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.11.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2010-03-25 08:05 UTC by Martin Pitt
Modified: 2010-04-01 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gvfs-mount -oi (3.11 KB, text/x-log)
2010-03-25 08:05 UTC, Martin Pitt
  Details
monitor patch (943 bytes, patch)
2010-03-25 12:11 UTC, Michael Chudobiak
none Details | Review

Description Martin Pitt 2010-03-25 08:05:54 UTC
Created attachment 157033 [details]
gvfs-mount -oi

* Plug in camera (I have a libgphoto2 supported one, not UMS)
 * gvfs media dialog pops up, select gthumb
 * I import pictures, and then get to the main screen, which (amongst other things) shows the Canon camera in the sidebar
 * I switch off the camera, since I'm done with importing
 * Camera does not go away in the side bar, and clicking on it yields an error.

I then noticed that when gthumb is already running when I switch on the camera, it does not appear either. Seems it does not react to hotplug events?

It should be pretty obvious, but I attach the gvfs-mount -oi log for reference. I didn't find a --debug switch for gthumb, and it did not print anything meaningful to stderr.
Comment 1 Paolo Bacchilega 2010-03-25 10:39:06 UTC
the code to react to media changes is already there, precisely in gthumb/gth-file-source-vfs.c, it just listens to "mounts-changed" events and filters out shadowed mounts.
Comment 2 Michael Chudobiak 2010-03-25 11:47:47 UTC
I can confirm that the camera remains in the folder tree even after being disconnected.

- Mike
Comment 3 Michael Chudobiak 2010-03-25 12:11:30 UTC
Created attachment 157053 [details] [review]
monitor patch
Comment 4 Paolo Bacchilega 2010-03-25 15:04:22 UTC
Michael, 

your patch didn't work for me, however after connecting to "mount-added" and "mount-removed" as well, it works again.  

I've applied it to master now, thanks.