GNOME Bugzilla – Bug 613858
updated thumbnail frame for image previews
Last modified: 2010-03-31 21:32:00 UTC
Created attachment 157026 [details] new thumbnail frame I made a new thumbnail frame for image previews in nautilus. The current looks old and really needed some love. In my opinion, it looks much nicer and less crude than the current. Attached the file. Also, the margins need to be adjusted in libnautilus-private/nautilus-thumbnails.h: #define NAUTILUS_THUMBNAIL_FRAME_LEFT 3 #define NAUTILUS_THUMBNAIL_FRAME_TOP 3 #define NAUTILUS_THUMBNAIL_FRAME_RIGHT 3 #define NAUTILUS_THUMBNAIL_FRAME_BOTTOM 3
A preview can be found here: http://twitpic.com/1apt5b
Thanks for your work, I committed this to master after the approval from r-t. commit de23258a5b70b7237cf972b4689731763eb19ebf Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Thu Mar 25 17:58:00 2010 +0100 Use a better thumbnail frame for image previews. Thanks to Hylke Bons for working on this. Closes bug #613858.
well, personally i think this frame matches the moblin style. why not change the frame margins to something bigger so we could provide a frame image which adds a nice drop shadow effect? i also made a new frame image and the problem was the little margins, so now the frame margins are all the same (3px) at least but if it where something like 10px (is this possible without problems?) on every side we could make much nicer thumbnail frames...
Created attachment 157381 [details] better nautilus thumbnail frame for pre 2.30 versions
(In reply to comment #3) > well, personally i think this frame matches the moblin style. why not change > the frame margins to something bigger so we could provide a frame image which > adds a nice drop shadow effect? I'm not really a fan of drop shadows in widgets themes. > i also made a new frame image and the problem was the little margins, so now > the frame margins are all the same (3px) at least but if it where something > like 10px (is this possible without problems?) on every side we could make much > nicer thumbnail frames... I like your mockup, but don't see any clash of styles of the one that is in right now (the 3.0 theme will fit better). Maybe we can make this image themeable through gtkrc? I guess this is somethink worth changing for theme makers.
i know, drop shadow can be bad for widgets, but it's totally common for example on the web for images or videos, so i think it works pretty good. of course the effect has to be very subtle. i'm not sure but i think other OS also use drop shadow effects for preview icons. i didn't mean that your mockup doesn't fit but i think it would be no problem to increase the margins a little bit so everybody has a little bit more freedom to change the appearance of the system.
(In reply to comment #6) > i didn't mean that your mockup doesn't fit but i think it would be no problem > to increase the margins a little bit so everybody has a little bit more freedom > to change the appearance of the system. Right, we can have these margins adjustable as well in gtkrc through style properties.
If you feel those settings are worth some gtkrc style properties additions, please file a separate bug.
... there is a problem with new borders ... they only look somewhat "good" on white background. But look very strange on any other. See attached screenshot
Created attachment 157396 [details] borders on dark background new borders looks strange on dark background
seems this needs a little more testing and discussing... since we have to update this file again i would like to ask if we can change the frame margins in this .h file to a bigger value? it should not bring any problems but give a little more possibilities if you want to change that image easily.
Created attachment 157403 [details] another frame for < 2.30 an updated version of my frame (which is very similar to hbons style but based on a drop shadow and not a simple stroke) which works nice on different backgrounds.
Created attachment 157404 [details] screenshot for another frame testing different images on different backgrounds
(In reply to comment #13) > Created an attachment (id=157404) [details] > screenshot for another frame > > testing different images on different backgrounds i think you are right, it does look better on dark backgrounds. i do like the borders thicker (but you probably did that because it's set to 3 now). I'll make a new proposal with a shadow.
hmm ... looks much much better. There are few things to consider ... 1) border shouldn't t be too wide ... because they will look strange and fuzzy (2 or three pixel max). And they will look out of place because all icons have exactly 2 pixel wide borders. 2) borders should contain at least one bright (near white) and one dark (near black) color to look good on both, light and dark background.
(In reply to comment #15) > hmm ... looks much much better. There are few things to consider ... > glad you like it :) > 1) border shouldn't t be too wide ... because they will look strange and fuzzy > (2 or three pixel max). And they will look out of place because all icons have > exactly 2 pixel wide borders. > this can be fixed by increasing the margins in the .h file. 2px are just too few to make something nice. > 2) borders should contain at least one bright (near white) and one dark (near > black) color to look good on both, light and dark background. thats exactly what i've done in the last frame image (and why it works on any background) and the same was done in the old original frame image but i'm using alpha values (and a totally different shadow effect) which makes everything much smoother. if you look very closely the roundness is a problem because of the 3px margins. i have to recompile nautilus myself if i want to test other frame margins right?
> i have to recompile nautilus myself if i want to test other frame margins > right? svetlik@svetlo:~$ sudo gimp /usr/share/pixmaps/nautilus/thumbnail_frame.png svetlik@svetlo:~$ nautilus -q to test 2px border just make border of the image transparent
(In reply to comment #17) yes, i know, but i mean to test other frame margins by editing the nautilus-thumbnails.h.