After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613795 - libmodplug's public header requires WORDS_BIGENDIAN
libmodplug's public header requires WORDS_BIGENDIAN
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal trivial
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-24 12:48 UTC by LRN
Modified: 2010-03-24 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Force configure to define WORDS_BIGENDIAN instead of leaving it undefined (769 bytes, patch)
2010-03-24 12:49 UTC, LRN 		rejected Details | Review
modplug: Define WORDS_BIGENDIAN to avoid undefined warning (815 bytes, patch)
2010-03-24 14:11 UTC, Benjamin Otte (Company) 		committed Details | Review

Description LRN 2010-03-24 12:48:28 UTC 
configure leaves WORDS_BIGENDIAN undefined (default behaviour for AC_C_BIGENDIAN), which doesn't work well with libmodplug's sndfile.h and recent introduction of compiler warning flags.
Comment 1 LRN 2010-03-24 12:49:31 UTC 
Created attachment 156968 [details] [review]
Force configure to define WORDS_BIGENDIAN instead of leaving it undefined
Comment 2 Benjamin Otte (Company) 2010-03-24 13:47:11 UTC 
I wonder if that patch could trigger weird problems with libraries doing "#ifdef WORDS_BIGENDIAN" which would always be true with your patch and if it wasn't better to put
#ifndef WORDS_BIGENDIAN
#define WORDS_BIGENDIAN 0
#endif
at the top of the modplug header.
Comment 3 LRN 2010-03-24 14:06:48 UTC 
I would rather fix modplug by doing
#if defined(WORDS_BIGENDIAN) && WORDS_BIGENDIAN
instead of 
#if WORDS_BIGENDIAN

I've mailed that to libmodplug maintainer. But he's far away, and -bad maintainers are close by ;)
Comment 4 Benjamin Otte (Company) 2010-03-24 14:11:32 UTC 
The following fix has been pushed:
06242ff modplug: Define WORDS_BIGENDIAN to avoid undefined warning
Comment 5 Benjamin Otte (Company) 2010-03-24 14:11:35 UTC 
Created attachment 156983 [details] [review]
modplug: Define WORDS_BIGENDIAN to avoid undefined warning