After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613786 - [PLUGIN-MOVE] Move imagefreeze to gst-plugins-good
[PLUGIN-MOVE] Move imagefreeze to gst-plugins-good
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-24 11:18 UTC by Sebastian Dröge (slomo)
Modified: 2010-05-11 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2010-03-24 11:18:20 UTC
imagefreeze should be moved to gst-plugins-good. It has documentation and unit tests and should be ready.
Comment 1 Tim-Philipp Müller 2010-03-24 11:33:24 UTC
Sure, but not in this cycle, next is core/base/good, and then good/ugly/bad again in May, see http://gstreamer.freedesktop.org/wiki/ReleasePlanning2010, so unsetting blocker again for now :)
Comment 2 Tim-Philipp Müller 2010-05-05 09:34:16 UTC
Shall we move this in this cycle? Is it going to go into its own plugin or is there a suitable plugin we can merge this into?


One negotiation issue I noticed:

gst-launch-0.10 filesrc location=foo.jpg ! jpegdec ! ffmpegcolorspace ! imagefreeze ! ximagesink
ERROR: from element /GstPipeline:pipeline0/GstFileSrc:filesrc0: Internal data flow error.
Additional debug info:
gstbasesrc.c(2547): gst_base_src_loop (): /GstPipeline:pipeline0/GstFileSrc:filesrc0:
streaming task paused, reason not-negotiated (-4)
Comment 3 Sebastian Dröge (slomo) 2010-05-05 10:26:27 UTC
(In reply to comment #2)
> Shall we move this in this cycle? Is it going to go into its own plugin or is
> there a suitable plugin we can merge this into?

I don't know... IMHO we should create a video plugin at some point, which contains videoscale and all that stuff.

But yes, we should probably move it for this cycle. Edward might want to use it in pitivi asap :)

> One negotiation issue I noticed:
> 
> gst-launch-0.10 filesrc location=foo.jpg ! jpegdec ! ffmpegcolorspace !
> imagefreeze ! ximagesink
> ERROR: from element /GstPipeline:pipeline0/GstFileSrc:filesrc0: Internal data
> flow error.
> Additional debug info:
> gstbasesrc.c(2547): gst_base_src_loop ():
> /GstPipeline:pipeline0/GstFileSrc:filesrc0:
> streaming task paused, reason not-negotiated (-4)

Fixed, thanks:


commit 1f6688b1a1de13c91dba905ef2f340642ec363b4
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed May 5 12:23:56 2010 +0200

    imagefreeze: Set fixed caps on the correct pad
    
    This makes the sink getcaps function actually used instead of using
    the fixed caps function for it.
Comment 4 Tim-Philipp Müller 2010-05-11 13:34:35 UTC
commit bb93d06ca0e7eec762e3c21a0b48a6da9471b5a7
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue May 11 14:02:33 2010 +0100

    Remove imagefreeze plugin/element.
    
    It has been moved to gst-plugins-good.
    
    See #613786.


commit 9cc52f2e0708620427957bdd2e3708aa7b744802
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue May 11 14:23:47 2010 +0100

    Move imagefreeze plugin from -bad to -good
    
    Hook up build infrastructure, docs and unit test for new plugin.
    
    Fixes #613786.