For bug reporters: If File a bug does not list a project, check GNOME GitLab instead (exceptions: Doxygen, GnuCash, LDTP)!
For project maintainers and developers: After evaluation, the mass migration from Bugzilla to GitLab has started (more info on GitLab).
Bug 613732 - [PATCH] gobject.py: Don't install frame filters when GDB does not support them
[PATCH] gobject.py: Don't install frame filters when GDB does not support them
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-03-23 19:14 UTC by Damien Lespiau
Modified: 2014-02-25 19:27 UTC (History)
6 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't install frame filters when GDB does not support them (2.29 KB, patch)
2010-03-23 19:14 UTC, Damien Lespiau 		committed Details | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Damien Lespiau 2010-03-23 19:14:58 UTC 
Created attachment 156912 [details] [review]
Don't install frame filters when GDB does not support them

Stock GDB (both versions 7.0 and 7.1) does not come with the new
backtrace code and python API. To prevent an ugly python backtrace when
auto-loading gobject.py, let's catch the exception and not register the
FrameWrapper and the FrameFilter.
Comment 1 Iain Lane 2013-12-17 12:13:19 UTC 
Could someone review this?
Comment 2 Colin Walters 2013-12-17 13:18:17 UTC 
Review of attachment 156912 [details] [review]:

Sounds fine to me.
Comment 3 Colin Walters 2013-12-17 15:55:04 UTC 
BTW Iain, since I know you're an experienced developer, I would say
you should feel free to review/commit patches to GLib like this one
yourself too.  Particularly if you've tested it already.
Comment 4 Iain Lane 2013-12-17 15:59:54 UTC 
Thanks Colin; I don't have a git account though. I've always had people commit stuff for me. :-)
Comment 5 Michael Catanzaro 2013-12-26 15:33:08 UTC 
Can this one go into glib-2-38?
Comment 6 Tom Tromey 2014-02-25 19:27:08 UTC 
See bug #623552 for a more complete fix.
Note You need to log in before you can comment on or make changes to this bug.