After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613711 - Crash when hiding the search bar in browser mode
Crash when hiding the search bar in browser mode
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-23 15:53 UTC by Tomas Bzatek
Modified: 2010-03-24 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.07 KB, patch)
2010-03-23 15:53 UTC, Tomas Bzatek 		committed Details | Review
memory leak fix (731 bytes, patch)
2010-03-23 15:54 UTC, Tomas Bzatek 		committed Details | Review

Description Tomas Bzatek 2010-03-23 15:53:01 UTC 
Created attachment 156886 [details] [review]
proposed patch

Steps to Reproduce:
1. Open a browser
2. Click search icon
3. Enter something into search line and press enter
4. Delete the contents of the entry
5. Click the search button again to toggle search mode off

The attached silly patch should fix the issue, commit at your will, we're in hard code freeze now.
Comment 1 Tomas Bzatek 2010-03-23 15:54:54 UTC 
Created attachment 156887 [details] [review]
memory leak fix

Also consider freeing the locally created object
Comment 2 Tomas Bzatek 2010-03-24 16:05:34 UTC 
commit acb01f0fe637a64f92c1ff2188879b7c470ed0e0
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Wed Mar 24 17:00:35 2010 +0100

    Unref local query object when turning search off

commit a92a7bfcb2c7bb9f171724bc97b1c163f52c0fd7
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Wed Mar 24 17:00:21 2010 +0100

    Don't crash when hiding search bar with no text
    
    Happens in browser mode and only when search results pane is displayed