After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613588 - gvfs-afc doesn't compile with libimobiledevice 1.0
gvfs-afc doesn't compile with libimobiledevice 1.0
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-22 13:27 UTC by Christophe Fergeau
Modified: 2010-03-24 14:04 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Attachments
trivial patch to fix compilation (785 bytes, patch)
2010-03-22 13:27 UTC, Christophe Fergeau 		none Details | Review
Fix compilation with libimobiledevice 1.0.0 (1.56 KB, patch)
2010-03-22 14:32 UTC, Bastien Nocera 		none Details | Review
Fix compilation with libimobiledevice 1.0.0 (1.62 KB, patch)
2010-03-22 14:45 UTC, Bastien Nocera 		committed Details | Review

Description Christophe Fergeau 2010-03-22 13:27:08 UTC 
Created attachment 156737 [details] [review]
trivial patch to fix compilation

There was a trivial API change, patch attached
Comment 1 Bastien Nocera 2010-03-22 14:32:30 UTC 
Created attachment 156744 [details] [review]
Fix compilation with libimobiledevice 1.0.0

AFC_E_INVALID_ARGUMENT was renamed to AFC_E_INVALID_ARG
in http://github.com/MattColyer/libiphone/commit/36048ded8efda588a20b5cf284670a984f7cc650
Comment 2 Christophe Fergeau 2010-03-22 14:41:15 UTC 
The patch works here (with libimobiledevice 1.0) and looks good to me for older versions of the library.
Comment 3 Bastien Nocera 2010-03-22 14:45:42 UTC 
Created attachment 156750 [details] [review]
Fix compilation with libimobiledevice 1.0.0

AFC_E_INVALID_ARGUMENT was renamed to AFC_E_INVALID_ARG
in http://github.com/MattColyer/libiphone/commit/36048ded8efda588a20b5cf284670a984f7cc650
Comment 4 Tomas Bzatek 2010-03-24 10:29:02 UTC 
I think it's safe to push it, compatibility looks to be maintained with 0.9.7.
Can you please request a hard code freeze break?
Comment 5 Bastien Nocera 2010-03-24 14:04:15 UTC 
Attachment 156750 [details] pushed as 1d1ce86 - Fix compilation with libimobiledevice 1.0.0