After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613536 - [Overview] Postpone window repositioning while zooming
[Overview] Postpone window repositioning while zooming
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-21 22:20 UTC by Florian Müllner
Modified: 2010-03-24 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[Overview] Postpone window repositioning while zooming (1.90 KB, patch)
2010-03-21 22:20 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2010-03-21 22:20:10 UTC
The delayed repositioning of window previews gets pretty messed up when it is triggered while zooming a window.
Comment 1 Florian Müllner 2010-03-21 22:20:21 UTC
Created attachment 156689 [details] [review]
[Overview] Postpone window repositioning while zooming

After closing a window, the remaining previews are repositioned
after a timeout; when it is called while the user zooms a preview,
the window positions get all messed up, so postpone the positioning
in this case until the zoom ends.
Comment 2 drago01 2010-03-21 22:41:49 UTC
Review of attachment 156689 [details] [review]:

Looks good and works fine for me, just some minor nitpick about the variable name, feel free to either change it or to ignore if you disagree.

::: js/ui/workspace.js
@@ +133,3 @@
         this._inDrag = false;
 
+        this._windowZooming = false;

I'd call this _windowIsZooming or _windowZoomed (windowZooming sounds odd in this context).

But anyway not worth loosing sleep over it ;)
Comment 3 Florian Müllner 2010-03-24 18:54:14 UTC
Attachment 156689 [details] pushed as 8b3d485 - [Overview] Postpone window repositioning while zooming