After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613489 - signal problem with Xfce Terminal “text” preferences
signal problem with Xfce Terminal “text” preferences
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-21 14:43 UTC by Yves-Alexis Perez
Modified: 2013-01-04 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yves-Alexis Perez 2010-03-21 14:43:24 UTC
Hey,

I have a weird bug using Xfce Terminal. I already reported it to the Xfce bugzilla at http://bugzilla.xfce.org/show_bug.cgi?id=6331

Basically, using GTK+ 2.18.9, when closing the preferences window, all the “text” properties are reset to an empty string. Reverting to 2.18.6 (using packages from Debian Squeeze) fixes the problem, so it seems like a problem in GTK+.

It looks like a signal is sent (twice) when closing preferences window and the string returned in the handler is empty. The connect call is like:

g_connect(G_OBJECT (screen->preferences), "swapped-signal::notify::word-chars", G_CALLBACK (terminal_screen_update_word_chars), screen, NULL) 

(I stripped all the other connects).

the terminal_screen_update_word_chars() is like:

static void
terminal_screen_update_word_chars (TerminalScreen *screen)
{
  gchar *word_chars;

  terminal_return_if_fail (TERMINAL_IS_SCREEN (screen));
  terminal_return_if_fail (TERMINAL_IS_PREFERENCES (screen->preferences));
  terminal_return_if_fail (VTE_IS_TERMINAL (screen->terminal));

  g_object_get (G_OBJECT (screen->preferences), "word-chars", &word_chars, NULL);
  if (G_LIKELY (word_chars != NULL))
    {
      vte_terminal_set_word_chars (VTE_TERMINAL (screen->terminal), word_chars);
      g_free (word_chars);
    }
}

so at the time of closing the word_chars is an empty string.


If you need more information, please ask.

Cheers,
--
Yves-Alexis
Comment 1 Yves-Alexis Perez 2010-03-21 14:50:30 UTC
Yes, confirmed, when using 2.18.6 no signal is sent when closing the preferences window, while using 2.18.9 the signal is sent twice.
Comment 2 Yves-Alexis Perez 2010-03-21 15:07:07 UTC
I can't easily revert to intermediate version but I think it started to appear with 2.18.9 and we skipped 2.18.8, so my guess is that it's ok in 2.18.7 too.
Comment 3 Yves-Alexis Perez 2010-03-21 15:10:37 UTC
(sorry for the flood)

My guess is that it's related to the fixes to http://bugzilla.gnome.org/612505
Comment 4 Christian Persch 2010-03-21 17:57:14 UTC
Looks like a dup of bug 613241.
Comment 5 Yves-Alexis Perez 2010-03-21 18:03:29 UTC
It seems so, though I don't get why it's marked as fixed.
Comment 6 Matthias Clasen 2010-03-22 13:11:04 UTC
Its marked as fixed because the fix has been committed:

http://git.gnome.org/browse/gtk+/commit/?h=gtk-2-18&id=0fff51eab6427ca4d0ab679c1d994a2a36898a7d
Comment 7 Yves-Alexis Perez 2013-01-04 10:18:03 UTC
Fixed since ages.