After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613456 - animate scrollbar in single view mode
animate scrollbar in single view mode
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-21 02:26 UTC by Hylke Bons
Modified: 2010-05-09 08:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[linearView] Animate scroll bar size changes (1.79 KB, patch)
2010-05-08 22:46 UTC, Florian Müllner
committed Details | Review
[workspacesView] Animate showing/hiding of controls (1.89 KB, patch)
2010-05-08 23:59 UTC, Florian Müllner
committed Details | Review

Description Hylke Bons 2010-03-21 02:26:57 UTC
when removing/adding workspaces in single view mode it gets animated nicely. however the scrollbr doesn't animate and just "jumps" from one size to another.
Comment 1 Florian Müllner 2010-05-08 22:46:23 UTC
Created attachment 160613 [details] [review]
[linearView] Animate scroll bar size changes

When adding/removing workspaces in linear view, both workspaces and
scrollbar movement are animated, but the size of the scrollbar handle
changes abruptly. It is more consistent to animate the size change
as well.
Comment 2 drago01 2010-05-08 23:17:28 UTC
Review of attachment 160613 [details] [review]:

This looks fine, and does indeed make sense.

(Side note, we probably should animate hiding/showing the scrollbar too).
Comment 3 Florian Müllner 2010-05-08 23:39:58 UTC
Comment on attachment 160613 [details] [review]
[linearView] Animate scroll bar size changes

Attachment 160613 [details] pushed as 88211ed - [linearView] Animate scroll bar size changes

(In reply to comment #2)
> (Side note, we probably should animate hiding/showing the scrollbar too).

Good point - leaving bug open for now then...
Comment 4 Florian Müllner 2010-05-08 23:59:31 UTC
Created attachment 160614 [details] [review]
[workspacesView] Animate showing/hiding of controls

Some of the workspace view controls are hidden when the number of
workspaces is one (view toggle button, scroll bar in single view).
Use a fade effect instead of showing/hiding the control abruptly.

Is that the more or less what you had in mind?
Comment 5 drago01 2010-05-09 07:55:32 UTC
(In reply to comment #4)
> Created an attachment (id=160614) [details] [review]
> [workspacesView] Animate showing/hiding of controls
> 
> Some of the workspace view controls are hidden when the number of
> workspaces is one (view toggle button, scroll bar in single view).
> Use a fade effect instead of showing/hiding the control abruptly.
> 
> Is that the more or less what you had in mind?

Yes, even though it isn't as clearly visible as the scrollbar size change, the abrupt change was still odd.
Comment 6 drago01 2010-05-09 07:56:24 UTC
Review of attachment 160614 [details] [review]:

Looks good.
Comment 7 Florian Müllner 2010-05-09 08:34:13 UTC
Attachment 160614 [details] pushed as 2ca1fe3 - [workspacesView] Animate showing/hiding of controls