After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613405 - Ejecting drives does not run the same action as Nautilus
Ejecting drives does not run the same action as Nautilus
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-20 12:45 UTC by Milan Bouchet-Valat
Modified: 2010-03-24 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[placeDisplay] Prefer eject over unmount when applicable (1.53 KB, patch)
2010-03-20 14:14 UTC, Florian Müllner 		committed Details | Review

Description Milan Bouchet-Valat 2010-03-20 12:45:21 UTC 
When you click on the eject button in Nautilus, USB keys are completely turned off, not only unmounted. This corresponds to the "Eject" option of the right-click menu.

In the Shell, the key is not turned off, so it's more like "Unmount" or "Safely Remove". I think using the very same action would make sense - just a matter of calling the right GIO function, I guess.
Comment 1 Florian Müllner 2010-03-20 14:14:33 UTC 
Created attachment 156623 [details] [review]
[placeDisplay] Prefer eject over unmount when applicable

Clicking the eject button in the places display always triggers an
unmount action. In some cases like USB drives or DVDs, eject makes
more sense - it is also consistent with nautilus' behavior.
Comment 2 drago01 2010-03-20 14:46:35 UTC 
Review of attachment 156623 [details] [review]:

Looks good and it actually make sense to be consistent with the nautilus behavior here.

(You might have to wait for the 2.29.1 before committing though, unless Owen is fine with this going in now).
Comment 3 Milan Bouchet-Valat 2010-03-20 14:52:17 UTC 
...and of course, the ever active Florian has come up with a patch in one hour and a half!
Comment 4 Florian Müllner 2010-03-20 15:24:06 UTC 
(In reply to comment #3)
> ...and of course, the ever active Florian has come up with a patch in one hour
> and a half!

Of which one hour and a quarter were spent searching for a USB stick to test the patch ;)


(In reply to comment #2)
> (You might have to wait for the 2.29.1 before committing though, unless Owen is
> fine with this going in now).

I think we could argue that the patch is a bug fix rather than a feature addition, but as I didn't really expect the patch to be reviewed before the release anyway, I'm obviously fine with waiting ...
Comment 5 drago01 2010-03-20 15:46:07 UTC 
(In reply to comment #4)
> (In reply to comment #2)
> > (You might have to wait for the 2.29.1 before committing though, unless Owen is
> > fine with this going in now).
> 
> I think we could argue that the patch is a bug fix rather than a feature
> addition, but as I didn't really expect the patch to be reviewed before the
> release anyway, I'm obviously fine with waiting ...

Yeah you're right this is indeed more of a bugfix than a feature, so it should be fine I suppose.
Comment 6 Florian Müllner 2010-03-24 18:54:31 UTC 
Attachment 156623 [details] pushed as d1a1783 - [placeDisplay] Prefer eject over unmount when applicable