GNOME Bugzilla – Bug 613371
gst_element_class_set_details => gst_element_class_set_details_simple
Last modified: 2010-03-24 13:09:50 UTC
Created attachment 156591 [details] [review] patch The attached patch does that conversion. I want to deprecate gst_element_class_set_details() in core and would like to convert all modules so they keep compiling. However, I cannot check it in because gst-indent screws up completely here and mangles some files.
Yep, we'll fix it sooner or later... The indent script is not super perfect anyway, look what it does with the fragment source in gstgldeinterlace.c e.g. I never managed to completely replicate what it does with emacs... IIRC correctly I even found an indent bug while trying to debug it [1]. It's not that you cannot commit without running gst-indent complaining anyway, please submit a good git formatted patch with chmod -x .git/hooks/pre-commit git commit chmod +x .git/hooks/pre-commit We'll fix indentation another time. 1. Now that I think about it, it was actually a bug with element_details declarations :P so with your patch I could finally forget it. See http://www.mail-archive.com/bug-indent@gnu.org/msg00208.html
> Yep, we'll fix it sooner or later... > The indent script is not super perfect anyway, look what it does with the > fragment source in gstgldeinterlace.c e.g. > I never managed to completely replicate what it does with emacs... IIRC > correctly I even found an indent bug while trying to debug it [1]. For what it's worth, you can put markers like these into the code: /* *INDENT-OFF* */ /* *INDENT-ON* */ to make indent skip it. Benjamin: committed my own version of the patch, which is more or less the same as yours, sorry about that (I thought I had looked at yours and was under the impression that it contained indent problems, but it doesn't...) commit 6a15f2fb030a1cab4f602c2b3f744a5f4872639a Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Wed Mar 24 11:10:21 2010 +0000 gl: use gst_element_class_set_details_simple() Fixes #613371.
(In reply to comment #2) > > Yep, we'll fix it sooner or later... > > The indent script is not super perfect anyway, look what it does with the > > fragment source in gstgldeinterlace.c e.g. > > I never managed to completely replicate what it does with emacs... IIRC > > correctly I even found an indent bug while trying to debug it [1]. > > For what it's worth, you can put markers like these into the code: > > /* *INDENT-OFF* */ > > /* *INDENT-ON* */ > > to make indent skip it. Oh nice, didn't know about it, we could use it at least for the fragment sources. > Benjamin: committed my own version of the patch, which is more or less the same > as yours, sorry about that (I thought I had looked at yours and was under the > impression that it contained indent problems, but it doesn't...) Nope, the patch was ok, the indent problems are everywhere else :) Hence I asked him to resubmit it in the git way to give him the proper credit.