After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613288 - Display PNG information in image properties
Display PNG information in image properties
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Properties Dialog
2.28.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-19 00:19 UTC by Dynnikov Yaroslav
Modified: 2012-09-25 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clean up the image properties code (7.90 KB, patch)
2012-09-19 10:05 UTC, William Jon McCann 		committed Details | Review
Add extra data to the image properties (2.73 KB, patch)
2012-09-19 10:05 UTC, William Jon McCann 		accepted-commit_after_freeze Details | Review
Add extra data to the image properties (2.65 KB, patch)
2012-09-19 15:34 UTC, William Jon McCann 		committed Details | Review

Description Dynnikov Yaroslav 2010-03-19 00:19:00 UTC 
It would be nice to see content of PNG tEXt chunks (like "comment" or "author") on the "image" tab.
Same option works for JPG and some other types, but for PNG it doesn't.
Comment 1 William Jon McCann 2012-09-19 10:05:20 UTC 
Created attachment 224726 [details] [review]
Clean up the image properties code
Comment 2 William Jon McCann 2012-09-19 10:05:23 UTC 
Created attachment 224727 [details] [review]
Add extra data to the image properties

That includes PNG tEXt chunk information.
Comment 3 William Jon McCann 2012-09-19 10:18:25 UTC 
Test with http://www.schaik.com/pngsuite/ct1n0g04.png
Comment 4 Cosimo Cecchi 2012-09-19 15:01:49 UTC 
Review of attachment 224726 [details] [review]:

Looks good
Comment 5 Cosimo Cecchi 2012-09-19 15:05:06 UTC 
Review of attachment 224727 [details] [review]:

Looks good after we branch, since it introduces a number of new strings.

::: src/nautilus-image-properties-page.c
@@ +368,3 @@
+	append_option_value_pair (page, pixbuf, "tEXt::Comment", _("Comment"));
+
+	if (!append_option_value_pair (page, pixbuf, "Author", _("Author")))

Hmm, I think icc-profile is usually raw base64-encoded data, not sure it's worth displaying it as a string here.
Comment 6 William Jon McCann 2012-09-19 15:28:40 UTC 
Yeah I wasn't sure about that either. Should probably drop it here and do it in bug 626980.
Comment 7 William Jon McCann 2012-09-19 15:34:30 UTC 
Created attachment 224764 [details] [review]
Add extra data to the image properties

That includes PNG tEXt chunk information.
Comment 8 Cosimo Cecchi 2012-09-19 15:37:36 UTC 
Review of attachment 224764 [details] [review]:

++
Comment 9 William Jon McCann 2012-09-25 16:26:05 UTC 
Attachment 224726 [details] pushed as 07d18c6 - Clean up the image properties code
Attachment 224764 [details] pushed as a9c2a22 - Add extra data to the image properties