GNOME Bugzilla – Bug 613270
gnome-session is a little too pedantic when doing checks for its saved-session dir
Last modified: 2013-01-31 21:57:00 UTC
Created attachment 156506 [details] [review] Be more symlink friendly Right now gnome-session does a bunch of checks to make sure saved-session is a directory, but I'd like saved-session to also work as a symlink for a RHEL customer. This is to provide something akin to the old the old --choose-session interface. I'd also like to get a small graphical app Matthias wrote for selecting a session upstream as a configure compile-time option that's disabled by default.
(In reply to comment #0) > Created an attachment (id=156506) [details] [review] > Be more symlink friendly > > Right now gnome-session does a bunch of checks to make sure saved-session is a > directory, but I'd like saved-session to also work as a symlink for a RHEL > customer. This is to provide something akin to the old the old > --choose-session interface. Any reason to not reimplement --choose-session?
Created attachment 156775 [details] [review] add ui for choosing session This patch which was mostly written by Matthias, adds a session selector UI that gets run when the user chooses "Custom" at login. The UI allows the user to name a new session, or log into an existing session. Once logged in, the session will automatically save at log out.
(In reply to comment #1) > Any reason to not reimplement --choose-session? Well, there aren't strong reasons against readding --choose-session, but then there aren't strong reasons for reimplementing it either. A couple of weak reasons to keep it this way: 1) We're keeping the session selection feature and gnome-session fairly isolated from each other. It's more like an add-on on top. This is desirable because the feature isn't something we probably want to promote given how many apps get session saving wrong. It was written to meet the special needs of a specific, constrained environment. There are clearly other specific, constrained environments where it's a useful feature, which is why I think this should get upstream. On the other hand, I still think there is value in keeping the feature and gnome-session fairly separated. 2) It was slightly easier to implement this way, and that implementation is already done. Anyway, I could probably be convinced to redo things in terms of a fresh --choose-session implementation if there is a compelling reason to.
Created attachment 164045 [details] [review] Add rename support and use infobar
Created attachment 167012 [details] [review] make license gpl2 not gpl3
Thanks for the patch. This works, I'm sure, but that's not really the way I imagined things. It feels like a tool on top of GNOME instead of being integrated in GNOME. More specifically: + I still don't get why we use a symlink for this. There's no need for that: we can just use "gnome-session --saved-session MySavedSession" + the UI to select a custom session is actually redundant with the GDM session selector, IMHO. To me, we should make it possible in GDM to select a saved session from gnome-session. + there's of course the question of how to create a new custom session. I'd just integrate that in gnome-session-properties and/or in gnome-session-save. For example, we can change gnome-session-properties to have a combo box to select a name for the saved session, and to have a combo box that would be "always save on logout", "save on next logout only", "save now". Okay, "save now" wouldn't work well for the combo box, but you get the idea.