GNOME Bugzilla – Bug 613243
Join room should be greyed out for AIM
Last modified: 2010-03-29 15:35:39 UTC
Telepathy-gabble currently dont support AIM group chat so when clicked on room>Join and AIM selected the text field for room and server should be greyed out so that users dont get tricked into believing there might be a porblem with the information they typed or some error.
originally reported at: https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/540525
We should check if the connection support group text channel.
I fixed this in the code thanks to some help in #empathy (wrote a new account filter empathy_account_chooser_filter_supports_multichat). I am looking in to how to properly upload a patch.
Created attachment 156466 [details] [review] A patch which adds empathy_account_chooser_filter_supports_multichat to filter out protocols that don't support multiuser chat
Review of attachment 156466 [details] [review]: Thanks a lot for your patch. It looks good from a code pov but should be done in a different way. ::: libempathy-gtk/empathy-account-chooser.c @@ +903,3 @@ + */ +gboolean +empathy_account_chooser_filter_supports_multichat (TpAccount *account, I wouldn't add this function here. It should be in new-chatroom-dialog as a static function. @@ +906,3 @@ + gpointer user_data) +{ + TpConnection *connection; /* largely copied from empathy-new-message-dialog.c */ No need to specify that. :)
Created attachment 156469 [details] [review] A patch which adds empathy_account_chooser_filter_supports_multichat to filter out protocols that don't support multiuser chat, rev. 1
Review of attachment 156469 [details] [review]: ::: src/empathy-new-chatroom-dialog.c @@ +131,3 @@ static void new_chatroom_dialog_button_close_error_clicked_cb (GtkButton *button, EmpathyNewChatroomDialog *dialog); +static gboolean empathy_account_chooser_filter_supports_multichat (TpAccount *account, You can avoid this prototype by defining this function before empathy_new_chatroom_dialog_show
Created attachment 156471 [details] [review] A patch which adds empathy_account_chooser_filter_supports_multichat to filter out protocols that don't support multiuser chat, rev. 2
Looks good; thanks a lot! We are now in code freeze, so I have to ask approval before merging this patch.
Merged; will be in 2.30.1. This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.