After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613214 - totem subtitle plugin cannot contact opensubtitles.org
totem subtitle plugin cannot contact opensubtitles.org
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Subtitle Downloader plugin
2.29.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-03-18 08:33 UTC by Robert Moerland
Modified: 2010-03-20 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to show small change in opensubtitles.py (www->api) (492 bytes, application/octet-stream)
2010-03-18 08:33 UTC, Robert Moerland
  Details
Corrected patch for opensubtitles.py to address the issue described (492 bytes, patch)
2010-03-20 07:02 UTC, Robert Moerland
committed Details | Review

Description Robert Moerland 2010-03-18 08:33:55 UTC
Created attachment 156434 [details]
Patch to show small change in opensubtitles.py (www->api)

Reported earlier on launchpad (see https://bugs.launchpad.net/ubuntu/+source/totem/+bug/540533)

The subtitle plugin in Totem cannot contact the opensubtitles.org's database anymore, since the URL 'www.opensubtitles.org' isn't valid anymore for API calls. It apparently has changed to http://api.opensubtitles.org. The URL of the server for API calls is hard coded in opensubtitles.py, around line 319. After I changed 'www' into 'api', the opensubtitles.org database could be contacted again. I've attached a patch that shows the small change I've made.
Comment 1 Alex Kapranoff 2010-03-20 02:09:13 UTC
I confirm both the bug and the fix suggested. The patch attached by reporter is reversed but it's too trivial to redo. Please apply :) Thanks!
Comment 2 Robert Moerland 2010-03-20 07:02:16 UTC
Created attachment 156607 [details] [review]
Corrected patch for opensubtitles.py to address the issue described

Indeed got them reversed. Here's a corrected patch.
Comment 3 Philip Withnall 2010-03-20 14:07:02 UTC
Committed to master and gnome-2-28. Didn't ask for a freeze break request because the change was sufficiently critical and low-risk. Thanks for the patch. :-)

commit b85a5b88f6532cbfd07bb677842611f52c056acc
Author: Robert Moerland <veel_mail@xs4all.nl>
Date:   Sat Mar 20 14:00:37 2010 +0000

    Bug 613214 — totem subtitle plugin cannot contact opensubtitles.org
    
    Fix the API URI for the opensubtitles.org plugin. Closes: bgo#613214

 src/plugins/opensubtitles/opensubtitles.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)