After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613208 - tooltips on window list pointless unless text is concatenated
tooltips on window list pointless unless text is concatenated
Status: RESOLVED OBSOLETE
Product: libwnck
Classification: Core
Component: tasklist
2.29.x
Other Linux
: Normal minor
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-18 02:03 UTC by Jason
Modified: 2018-01-24 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to make Window List only display tooltips if task name is ellipsized (4.11 KB, patch)
2010-03-19 18:12 UTC, Jason
needs-work Details | Review
Same as 1st patch but formatting is fixed (4.12 KB, patch)
2010-03-19 19:04 UTC, Jason
none Details | Review

Description Jason 2010-03-18 02:03:07 UTC
The tooltips on the window list in the bottom panel should only appear when the text within is concatenated. If this is not possible, the tooltips should be turned off.  Displaying the exact text of the application's button in the tooltip seems redundant and possibly confusing.

This  bug was originally reported in Launchpad for Ubuntu by user Kenneth Wimer:
https://bugs.edge.launchpad.net/ubuntu/+source/libwnck/+bug/531866
Comment 1 Jason 2010-03-19 18:12:32 UTC
Created attachment 156572 [details] [review]
Patch to make Window List only display tooltips if task name is ellipsized
Comment 2 Marcus Carlson 2010-03-19 18:35:42 UTC
Review of attachment 156572 [details] [review]:

I just took a quick look at the formatting. See below

::: libwnck/tasklist.c
@@ +3158,3 @@
+			  WnckTask  *task)
+{
+  wnck_set_tooltip_text(task);

should be 
wnck_set_tooltip_text (task);

@@ +4281,3 @@
+
+void
+wnck_set_tooltip_text(WnckTask *task)

should be
	wnck_set_tooltip_text (WnckTask *task)

@@ +4290,3 @@
+
+  // Set button's tooltip to label text, but only if label is ellipsized
+  if(pango_layout_is_ellipsized(layout))

should be
	 if (pango_layout_is_ellipsized (layout))

etc etc
Comment 3 Jason 2010-03-19 19:04:40 UTC
Created attachment 156578 [details] [review]
Same as 1st patch but formatting is fixed
Comment 4 Jason 2010-09-06 17:30:50 UTC
This is a pretty simple fix, any time frame on a review? :)
Comment 5 GNOME Infrastructure Team 2018-01-24 13:48:40 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libwnck/issues/115.