GNOME Bugzilla – Bug 613208
tooltips on window list pointless unless text is concatenated
Last modified: 2018-01-24 13:48:40 UTC
The tooltips on the window list in the bottom panel should only appear when the text within is concatenated. If this is not possible, the tooltips should be turned off. Displaying the exact text of the application's button in the tooltip seems redundant and possibly confusing. This bug was originally reported in Launchpad for Ubuntu by user Kenneth Wimer: https://bugs.edge.launchpad.net/ubuntu/+source/libwnck/+bug/531866
Created attachment 156572 [details] [review] Patch to make Window List only display tooltips if task name is ellipsized
Review of attachment 156572 [details] [review]: I just took a quick look at the formatting. See below ::: libwnck/tasklist.c @@ +3158,3 @@ + WnckTask *task) +{ + wnck_set_tooltip_text(task); should be wnck_set_tooltip_text (task); @@ +4281,3 @@ + +void +wnck_set_tooltip_text(WnckTask *task) should be wnck_set_tooltip_text (WnckTask *task) @@ +4290,3 @@ + + // Set button's tooltip to label text, but only if label is ellipsized + if(pango_layout_is_ellipsized(layout)) should be if (pango_layout_is_ellipsized (layout)) etc etc
Created attachment 156578 [details] [review] Same as 1st patch but formatting is fixed
This is a pretty simple fix, any time frame on a review? :)
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libwnck/issues/115.