GNOME Bugzilla – Bug 613195
altTab.js continued CSSification
Last modified: 2010-04-06 12:39:45 UTC
as a continuation of bug 597983, there is still some CSSification to be done: 1. All uses of POPUP_LIST_SPACING should go away; note that this single constant is used for multiple things which will split into separate declarations in the CSS: * AltTabPopup.actor's padding (which keeps AppSwitcher.actor and ThumbnailList.actor from touching the screen edges) * AltTabPopup.actor's spacing (between AppSwitcher.actor and ThumbnailList.actor) * SwitcherList._list's spacing 2. The arrow fg/bg colors should be picked out of CSS instead of being hardcoded as constants. Something like the cssBind code in bug 611647 may be useful here. As currently written there, it assumes a one-to-one mapping between actors and JS delegates, so it doesn't quite work for cases like SwitcherList.actor vs SwitcherList._list. So it would need to be made a little more complicated. (That's the same fix that's needed to make it work with appDisplay, as alluded to in that bug.)
Created attachment 156624 [details] [review] AppSwitcher: Use CSS instead of the hardcoded POPUP_LIST_SPACING constant The POPUP_LIST_SPACING constant was used for the AltTabPopup.actor's padding, AltTabPopup.actor's spacing and SwitcherList._list's spacing. Switch to CSS and remove the constant.
Comment on attachment 156624 [details] [review] AppSwitcher: Use CSS instead of the hardcoded POPUP_LIST_SPACING constant >+ this.actor = new Shell.GenericContainer({ name: 'altTabPopup', reactive: true }); newline after the comma otherwise looks good, though it will need rebasing for the dual-monitor-fixing patch
Comment on attachment 156624 [details] [review] AppSwitcher: Use CSS instead of the hardcoded POPUP_LIST_SPACING constant Pushed rebased version as 5ff609e.
(In reply to comment #0) > 2. The arrow fg/bg colors should be picked out of CSS instead of being > hardcoded as constants. This part is done in bug 614516, so we can close this one.