After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613156 - cog can't be built against libpng 1.4.x
cog can't be built against libpng 1.4.x
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-17 14:24 UTC by LRN
Modified: 2010-03-17 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check for libpng >= 1.2 instead of libpng12 (892 bytes, patch)
2010-03-17 14:24 UTC, LRN
committed Details | Review
Use png_get_io_ptr() instead of accessing io_ptr directly (892 bytes, patch)
2010-03-17 14:25 UTC, LRN
committed Details | Review
Use "(png_infopp) NULL" instead of png_infopp_NULL (859 bytes, patch)
2010-03-17 14:25 UTC, LRN
committed Details | Review

Description LRN 2010-03-17 14:24:06 UTC
Because confnigure checks for libpng12 instead of libpng >= 1.2 and because gstlogoinsert.c uses io_ptr directly. And because it uses png_infopp_NULL which is not supported in libpng 1.4.x
Comment 1 LRN 2010-03-17 14:24:49 UTC
Created attachment 156357 [details] [review]
Check for libpng >= 1.2 instead of libpng12
Comment 2 LRN 2010-03-17 14:25:17 UTC
Created attachment 156358 [details] [review]
Use png_get_io_ptr() instead of accessing io_ptr directly
Comment 3 LRN 2010-03-17 14:25:42 UTC
Created attachment 156359 [details] [review]
Use "(png_infopp) NULL" instead of png_infopp_NULL
Comment 4 Sebastian Dröge (slomo) 2010-03-17 14:32:15 UTC
commit 20c1e3b6052723ee3c23d71791b77858defebd56
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Mar 17 14:29:31 2010 +0300

    cog: Use "(png_infopp) NULL" instead of png_infopp_NULL

commit e44da2ded0c23c6348383dd3d5bfd6955ba97df7
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Mar 17 14:23:41 2010 +0300

    cog: Use png_get_io_ptr() instead of accessing io_ptr directly

commit 12fb30749499382aa436802972d28cc888e78af4
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Mar 17 14:21:53 2010 +0300

    cog: Check for libpng >= 1.2 instead of libpng12