GNOME Bugzilla – Bug 613136
remove over-restrictive assert from meta_prefs_get_workspace_name()
Last modified: 2010-04-13 12:53:38 UTC
Created attachment 156349 [details] [review] patch that removes assert The initial value of the workspace_names array are NULL unless the gconf key exists; the absence of a preference key is not a good enough reason to abort (e.g., Moblin ships with a very minimal gconf key set).
Review of attachment 156349 [details] [review]: Problem is real, but fix doesn't look right to me - we shouldn't just return NULL there. The current situation is a regression from: http://git.gnome.org/browse/mutter/commit?id=2d57b1b4 Prior to that commit all values in the workspace_names array would either have values set by the user, or Workspace %d. After the commit, those not in GConf would have empty values. (This applies to workspaces 17-36 even with the standard GConf schemas) I'll attach an alternate patch.
Created attachment 158507 [details] [review] Make sure all workspaces have a non-empty, non-null name The change to using gconf_client_all_entries() in commit 2d57b1b4 meant that workspaces without a GConf key for their name were not getting a name at all. Fix this by doing a post-processing loop to set workspace names that were not otherwise set. Alternate to patch from Tomas Frydrich
Review of attachment 158507 [details] [review]: This looks OK.
(In reply to comment #2) > Alternate to patch from Tomas Frydrich ^ That should be a 'y' please ;-), but yep, the alternate patch is fine.
Fixed mispelling prior to pushing. Sorry about that! Attachment 158507 [details] pushed as 94d47dc - Make sure all workspaces have a non-empty, non-null name